numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.2k stars 227 forks source link

xfce notification theme broken #743

Open fish47 opened 4 years ago

fish47 commented 4 years ago

before before

after after

source https://bbs.archlinux.org/viewtopic.php?id=254478

fish47 commented 4 years ago

should we specify a standalone gtk.css for xfce? https://github.com/numixproject/numix-gtk-theme/issues/677

khurshid-alam commented 4 years ago

Please specify version for xfce or numix, https://github.com/numixproject/numix-gtk-theme/commit/8083a96a14472836f5c1090d8a0a2fa2e4633ffb should have fixed this.

Flowneee commented 4 years ago

Please specify version for xfce or numix, 8083a96 should have fixed this.

Hi, I'm the original author of thread on arcglinux.org. Currently my version of numix is local/numix-gtk-theme-git 2.6.7.r51.b652b19-1, so (I assume) it refer to commit b652b19, which is latest in current master. About xfce version: 4.14 (everything is latest from arch repo). The only exception is xfce4-notifyd: 0.4.4, because latest is not working correctly with numix.

ochosi commented 4 years ago

Notifyd was updated with respect to its base/fallback class so your code doesn't apply anymore. The "osd" class was dropped so you need to at least drop the lines referring to it: https://github.com/numixproject/numix-gtk-theme/blob/b652b19b76814862f7e87a66e936565809fbf972/src/gtk-3.20/scss/apps/_xfce.scss#L32 https://github.com/numixproject/numix-gtk-theme/blob/b652b19b76814862f7e87a66e936565809fbf972/src/gtk-3.20/scss/apps/_xfce.scss#L39

This will likely improve things but you may also have to specify a few more things like colors. The new fallback class is "keycap" (because this looks best out of the box with Adwaita).

darkshram commented 3 years ago

Commit 8083a96 only works for xfce4-notifyd 0.4. My suggestion to have this issue fixed is to discard the current code for xfce4-notifyd, and do the same as Greybird gtk theme and create a Numix specific stylesheet file for xfce4-notifyd based on the Greybird stylesheet for xfce4-notifyd and just adapt it with the Numix color palette and style. Currently, Numix includes a gtkrc file for gtk2 based xfce4-notifyd, and there is no gtk.css file for the gtk3 based one.

Something like this (replacing $osd_bg with #444 and $osd_fg with #eee?) for xfce4-notifyd-0.4/gtk.css:

#XfceNotifyWindow {
    background-color: shade($osd_bg, 0.3);
    color: $osd_fg;
    border: 1px solid shade($osd_bg, 0.6);
    border-radius: 6px;
}

#XfceNotifyWindow button {
    background-image: none;
    background-color: shade($osd_bg, 0.3);
    color: $osd_fg;
    border-color: shade($osd_fg, 0.35);
    border-radius: 3px;
}

#XfceNotifyWindow button:hover {
    background-color: shade($osd_bg, 0.4);
    border-color: shade($osd_fg, 0.45);
}

#XfceNotifyWindow label#summary {
    font-weight: bold;
}

#XfceNotifyWindow progressbar {
    min-height: 6px;
    border-radius: 3px;
}

#XfceNotifyWindow progressbar progress {
    background-image: none;
    background-color: $osd_fg;
    border: none;
    box-shadow: none;
}

#XfceNotifyWindow progressbar trough {
    background-image: linear-gradient(to bottom,
                                      shade($osd_bg, 0.65),
                                      shade($osd_bg, 1.25)
                                      );
    border: 1px solid shade($osd_bg, 0.2);
    border-radius: 3px;
    padding: 1px 0;
}
c1ph3rl1nux commented 3 years ago

@darkshram Your suggestion works for me. See screenshots.. Screenshot_2 Screenshot_1

PS: if you have some time maybe you could take a look at this #752? All day I've been trying to figure out why Lightdm is ignoring Numix's login window background color. Any help or input would be welcome, cheers in advance!