search

numixproject / numix-icon-theme

Official base icon theme from the Numix project.
http://numixproject.github.io
GNU General Public License v3.0
775 stars 86 forks source link

Qt tray-icons don't display properly #1342

Open zensubz opened 4 years ago

zensubz commented 4 years ago

Hi,

I have an issue with Qt tray-icons being displayed with Numix-Circle in MATE desktop. Quite a few of the tray-icons (mainly for the Qt5 apps I have tested) display a sort of ellipse-like look in systray (pl. see the attached pic).

tray-icons-at-27px

Will there be any possibility of fixing this issue..? Many thanks.

palob commented 4 years ago

Those icons aren't supposed to be Circle (app) icons but rather something like the redshift (I assume it is) icon in the first place. But this is probably due to those apps choosing wrong icon names for their tray icons, so something we can't fix. I don't know what causes the distortion but I experienced it some time ago with GNOME or Cinnamon IIRC.

Have you got any other custom icon theme to compare with?

zensubz commented 4 years ago

Ok, I have tried with Papirus icon theme, and here is the comparison:

papirus-24px

Looks like all of them are ok in case of Papirus (except the mega app tray-icon).

Edit: I use qt5ct to theme qt5 apps, and this time the panel size has been kept at 24px (the first one with numix-circle issue has the panel size of 27px just to highlight the ellipse-like distortion).

palob commented 4 years ago

Hmm, so there is definitely something we can do. I for one have never delved much into tray icons since I turn them off usually. For Flameshot for instance Papirus has icons named flameshot-tray. Do they show up without further ado or does it involve Hardcode-Tray?

zensubz commented 4 years ago

I used Papirus icon theme via qt5ct, and no further makeover was done (Hardcode-Tray hasn't been used). Checked if other (qt5) apps have something like *-tray in (names): for vlc, it is vlc-panel, for simplescreenrecorder it is simplescreenrecorder-panel, and for mega looks like they have missed out..!

Perhaps a combination of -tray.svg and -panel.svg may work in case of numix-circle..?

palob commented 4 years ago

When no custom theme is applied, do the tray icons look exactly like the respective original app icons? Or does any of the apps in question ship their own tray icons out of the box?

palob commented 4 years ago

Design wise those dedicated tray icons seems the same as the monochrome symbolic app icons which GNOME apps ship for the top bar.

zensubz commented 4 years ago

Ok, this time I checked by removing the qt5ct startup, removed the config folder of qt5ct, and so no icon-theme was picked via qt5ct - but then, the tray-icons were like the ones I had posted in my first-comment - presented an ellipse-like distortion. If I am not wrong, it looks like the (qt5) apps as such pick-up the icon-theme that is defined for gtk2/3 (for the entire desktop), and so were picking up numix-circle (presenting the ellipse-like distortion).

If I define Adwaita as the icon-theme via qt5ct, then partially the tray-icons are ok - vlc and simplescreenrecorder seem to be fine, but others suffer - in the sense, perhaps, the way the tray-icons are defined in icon-themes (such as hicolor) might be affecting apps like flameshot and megasync, which now tend to pick up their respective icons from hicolor (pl. see the attached screenshot).

adwaita-27px

zensubz commented 4 years ago

It is strange that the tray-icons are properly displayed in Cinnamon (LMDE), as seen in the screenshot:

numix-circle-cinnamon-28px

Edit: I could test only vlc, simplescreenrecorder and flameshot - megasync was not installed in my LMDE; vlc doesn't present a separate tray-icon instead it takes-up a form of sound-icon (as is the case with many audio/video apps in Cinnamon).

Foggalong commented 4 years ago

Moved the issue over here since this is almost certainly where the fix will have to happen.