search

numixproject / numix-icon-theme

Official base icon theme from the Numix project.
http://numixproject.github.io
GNU General Public License v3.0
779 stars 87 forks source link

Additional percentage level battery status icons in fixed size directories 16, 22 and 24 #331

Closed dirtydancing closed 9 years ago

dirtydancing commented 9 years ago

Following-up on my comment over at https://github.com/numixproject/numix-icon-theme/issues/107#issuecomment-76519738, I have done some testing with the additional percentage battery status icons introduced for Ubuntu 15.04 for 10%, 30%, 50%, 70%, 90%:

These (tested with testing battery icons size 22x22) are already working in current daily Ubuntu 15.04, and at the same time they do not cause any breakage in Ubuntu 14.10, which simply does not pick up these additional battery status icons. Also tested against elementary OS Freya Beta 2, based on Ubuntu 14.04 LTS: just like in Ubuntu 14.10, the additional battery status icons simply do not get picked up.

These additional icons are useful because they provide a finer granulation, and because they address the issue of a too early warning status with the present icons, cf. bug report at https://bugs.launchpad.net/ubuntu-ux/+bug/1388235.

Screenshots when tested simultaneously against Ubuntu 14.10 (above) and Ubuntu 15.04 (VM, below):

battery_28

battery_20

battery_14

battery_9

battery_4

battery_charging-2

battery_charging-5

battery_charging-21

battery_charging-35

battery_charging-90

This is how these additional battery status icons (10%, 30%, 50%, 70%, 90%) could be fit into the present ones, which in this overview have been left untouched (additionally all selected for visual contrast).

battery-new-levels

battery-new-levels2

I would create a pull request for these myself, but I am not yet very familiar with Inkscape (for the icon overview above I just scaled the already existing bars, which of course does not work for the charging status battery icons).

@wa4557 Are you interested in contributing these? For bar height in the screenshots above, I used px (new sizes bold) 2,5 orange - 4 orange - 5,5 - 7 - 8,5 - 10 - 11,5 - 13 - 14. In addition, the battery icons seem to use #dedede instead of #dcdcdc, so this might be an opportunity to make these consistent as well. From my perspective, adding these battery status icons makes sense even if there is a status icons redesign in the future, because this establishes a baseline on which such redesign could build upon.

The additional battery status icons in question here are marked yellow in this overview:

ca8cdf3c-bf37-11e4-8d9b-a2d16276d471

andia89 commented 9 years ago

Sure I'm happy to do that :)

dirtydancing commented 9 years ago

Fantastic! :-)

andia89 commented 9 years ago

@dirtydancing Can you push the icons you did (without the charger) to a branch of your numix-fork? There's no point in doing them twice...

dirtydancing commented 9 years ago

@wa4557 Pushed the icons from the overview above to the folder testing-battery-22x22 in the branch testing-battery https://github.com/dirtydancing/numix-icon-theme/tree/testing-battery

andia89 commented 9 years ago

Fantastic thanks, since the new status icons arrived, there won't be any double work neither