search

numixproject / numix-icon-theme

Official base icon theme from the Numix project.
http://numixproject.github.io
GNU General Public License v3.0
780 stars 87 forks source link

Elementary Freya Support [$15] #437

Open bilelmoussaoui opened 9 years ago

bilelmoussaoui commented 9 years ago

Hello, I would like to report some missing icons/symlinks

Already added icons from old issue

As there's too many icons, i couldn't upload them all.. So if someone wants working on this i would be happy to try to do it. I will add more asap. Thank you

andia89 commented 9 years ago

Concerning your second screenshot: None of those icons is supported (except the trash-can) there are just a few .pngs in the Numix-folders that are remnants from the gnome-icon theme i suppose. So you can add them to your list. The "drafts" icon is probably gtk-edit

The missing icons in your second screenshot (you can add them to your list):

but I wasn't able to find "Drafts"

bilelmoussaoui commented 9 years ago

I will add those icons soon. I'm trying to find an other icon capture du 2015-04-09 13 23 19 but i couldn't find it anywhere..

bilelmoussaoui commented 9 years ago

I did used a python script to check the difference between two folders.


folder1 = '/usr/share/icons/elementary/'
folder2 = '/usr/share/icons/Numix/'
folders_to_compare = ['actions','animations','categories','devices','emblems','mimes','places']

def get_extension(f):
    extension = f.split(".")
    return extension[len(extension) - 1]

def diff_folders(folder1, folder2,folders_to_compare):
    for folder in folders_to_compare:
        dir1 = os.listdir(folder1+folder)
        for d1 in dir1:
            if d1.isdigit() and os.path.isdir(folder2+d1+"x"+d1+"/"+folder):
                dir2 = os.listdir(folder1+folder+"/"+d1)
                dir3 = os.listdir(folder2+d1+"x"+d1+"/"+folder)
                for d2 in dir2:
                    if not(d2 in dir3) and get_extension(d2) == "svg": 
                        print("- [ ] " +folder1+folder+"/"+d1+"/"+d2)

diff_folders(folder1,folder2,folders_to_compare)
bilelmoussaoui commented 9 years ago

@Foggalong I've added a bounty on this and on #450 , would you like to add them to the title? :) Thanks!

Foggalong commented 9 years ago

I've contacted the Bounty Source team about why our account isn't working properly. They do a good thing with the site, but it's not half buggy at times.

andia89 commented 9 years ago

@bil-elmoussaoui This is true for #450 as well. Is it possible to remove double counted icons (probably by slightly modifying your python script?). help-info.svg for example is here 6 times...

bilelmoussaoui commented 9 years ago

I updated this one ;)

andia89 commented 9 years ago

@bil-elmoussaoui Hmm it seems to me that you made some errors. A lot of icons are already present in numix (network-wired network-wireless, etc...) Maybe you compared to an outdated version?

bilelmoussaoui commented 9 years ago

Nop i'm using the latest version of both, i guess this happend because i'm comparing folders and some of icons are in devices in Numix and they're somewhere else in Elementary :P

andia89 commented 9 years ago

Ah ok. I'll try to think of some short bash commands to show the differences in both files. Something using diff might do the trick...

andia89 commented 9 years ago

@bil-elmoussaoui I figured out an easy way to do this, if you could run that it shows really only the icons that are in elementary icon theme and not in Numix or Numix-Circle

#!/bin/bash

diff=$(find "$1" -regex ".*\.\(svg\|png\)" -printf "%f\n" | sed 's/\..*//' | sort | uniq)
for var in ${@:2}
do
    first=$(find "$var" -regex ".*\.\(svg\|png\)" -printf "%f\n" | sed 's/\..*//' | sort | uniq)
    diff=$(comm -23 <(echo "$diff") <(echo "$first"))
done

for f in $diff
do
    echo  "- [ ] "$f
done

EDIT2: I redid my script which works pretty good now. Call it by doing script /path/to/which/you/want/to/compare/ /path/to/base/ /path/to/circle/

bilelmoussaoui commented 9 years ago

@wa4557 i tried this and i have more than 500 lines in meld2.txt :P

andia89 commented 9 years ago

I get 318 :?

bilelmoussaoui commented 9 years ago

I will check this again later

Foggalong commented 9 years ago

Just thought I'd join in - I too wrote a script to do this when I was on a quest to make Circle a more complete app theme :P

dirtydancing commented 9 years ago

Wow, quite a number of icons listed here :) Looking at the list, I can tell that e.g. printer-symbolic.svg definitely is present already in Numix base.

I am wondering: are all of these icons actually displayed in elementary OS?

E.g., I noticed that current Adwaita icon theme with Arch/GNOME 3.16 contains numerous "symbolic" icons more than Numix base (not talking about the new active app "symbolic" icons that are dealt with in https://github.com/numixproject/numix-icon-theme/issues/485). Still, I tend to report/push those only when I actually come across them, such as recently network-wired-disconnected-symbolic.svg, cf. https://github.com/numixproject/numix-icon-theme/issues/547. In Adwaita, e.g. there is also network-wired-acquiring-symbolic.svg, but in contrast to network-wireless-acquiring-symbolic.svg, so far I have not actually seen that one displayed in GNOME Shell, so I have not (yet) reported/pushed it.

andia89 commented 9 years ago

@dirtydancing I agree. I'm a bit reluctant to design these icons, because I fear that a lot of these icons are not needed (maybe the aren't used anymore; same goes for #450). I think it's a better approach to only fix icons that are really displayed somewhere. I personally haven't come across a non Numix icon (that is themeable) for a very long time...

Foggalong commented 9 years ago

Even if it's not something users come across it's good to have even the obscure ones so that when they do show up everything stays consistent.

andia89 commented 9 years ago

It's definitely the ultimate goal to have all the icons from all the icon themes present in numix, but on the other hand in circle you "only" fix icons if users report them i.e. they are displayed somewhere and bother them. By using this approach there is automatically some kind of "priority" which icons needs to be designed (those that are reported and seen by users).

By doing it this way and making just huge lists, a lot of effort is probably being put in creating unnecessary icons that are probably outdated and not used anymore... So the best way would be to just ditch the inheritance line in Numix, and let the user report all those ugly hicolor icons that show up :P

Foggalong commented 9 years ago

We actually don't with Circle - about a year ago I did exactly this, and went through all the major icon themes and made sure we covered all the app icons from all of them. It ended up being over a 1000 new icons and symlinks but they're all now in Circle. I did that then because we were at the lowest open issue count we'd ever had and didn't have much else to prioritise. We're now getting to a similar point with Numix Base.

The big problem is that most users never report missing icons. If you look through any screenshot community you'll find hundreds of people using icon themes with apps icons, and panel icons, and all sorts of things missing and bugged.

That aside, I'm looking down this list and seeing icons reported by @bil-elmoussaoui that we actually already have. It might be worth revising this list.

andia89 commented 9 years ago

Fair enough. In that case I'll try and contribute some of the icons. Although I might spare less time the next few weeks for creating icons :(

Foggalong commented 9 years ago

No worries about spending time on it, people do what they can :)

Foggalong commented 9 years ago

@bil-elmoussaoui @palob @wa4557 @dirtydancing

Just a PSA because you all seem to be working on lists like this - after you've done an icon on the list, don't remove it's entry from that list. Just put a tick in the box (or me to do so if you can't) so that we can keep track of progress and also have somewhere to reference back to if things go wrong.

andia89 commented 9 years ago

@bil-elmoussaoui When you're cleaning up this list (good luck for your finals btw. :) you have to consider that a few of the icons in your list are actually app icons and should be reported in circle rather than here And: could you use this package here to compare the icon themes? This should be the most up to date one: https://code.launchpad.net/elementaryicons

bilelmoussaoui commented 9 years ago

@wa4557 i checked this again and all the icons does not exists. For the preferences-*.svg icons, they must be add in Circle and in Base too

dirtydancing commented 9 years ago

I will say again that printer-symbolic.svg already exists :) (in 16x16/status, 22x22/status, 24x24/status and in scalable/devices)

andia89 commented 9 years ago

@bil-elmoussaoui Have you used the script I provided? It's quite robust. I get something like 509(?) icons that are missing. mail-move.svg for examle is also already there

bilelmoussaoui commented 9 years ago

@wa4557 I tried your script but i got a lot of missing icons.. Which is not the case. I'm using elementary OS as a default desktop with Numix and i only have a few missing icons

andia89 commented 9 years ago

Just because you don't see them doesn't mean they are not missing :P You should still report them

bilelmoussaoui commented 9 years ago

@wa4557 Done :P I used an other script to do that

palob commented 9 years ago

Was working on the icons showing up in Pantheon Photos image-adjust image-auto-adjust image-red-eyes object-straighten (the 4 rightmost ones in the screenshot)

A comparison of elementary and Numix (the three leftmost icons already existing and working) elementary numix

In the elementary theme the icons are present for the 24 px size. However after adding the new ones to Numix/24x24/actions they won't show up. error (In order to make the screenshot I've copied the icons over to elementary)

Is this just the icon cache striking again or due to the varying or due to the different size definitions?

elementary

[actions/24]
Size=24
Context=Actions
MinSize=8
MaxSize=32
Type=Scalable

Numix

[24x24/actions]
Size=24
Context=Actions
Type=Fixed
bilelmoussaoui commented 9 years ago

@palob i'm not sure that's a cache issue. Can you copy those icons to other sizes in Numix and try again? (32x32 & 22x22)

palob commented 9 years ago

@bil-elmoussaoui It was just a cache issue. RMing the Numix base cache resolved it while only having 24px in Numix.

So what about the design?

bilelmoussaoui commented 9 years ago

I love them! just the image-adjust icon, the colours doesn't really mean the same thing as the default icon. capture du 2015-07-11 03 58 08

palob commented 9 years ago

Yeah but gradients in the lines might be too much of a departure from the Numix style. Blackish/whitish colours (without unnumixy strokes around) are problematic w.r.t. bright/dark GUI themes. image-adjust2

dirtydancing commented 9 years ago

Great icons! :+1:

As to image-adjust: Yeah, this looks like a tricky one to do within the Numix syle.

Maybe simply make use of the already existing gtk-select-color in 24x24/actions?

gtk-select-color

palob commented 9 years ago

Two alts: alt1 alt2 Needle needs to be brighter and maybe the stick a bit shorter.

A bit colour tweaking needed for light GTK themes bright

andia89 commented 9 years ago

I like the first one. I don't think the second fits the icon name

dirtydancing commented 9 years ago

I prefer the first one as well, good call with the three circles for RGB. Also fits better with the other icons.

palob commented 9 years ago

@Foggalong Any more objections to the above drafts? Otherwise I'll tweak the colours and adapt them to all sizes.

Foggalong commented 9 years ago

No objections :)

palob commented 9 years ago

Just realised that some list items are Inkscape icons.

palob commented 9 years ago

@bil-elmoussaoui Do you happen to know where edit-flag and edit-mark are used?

bilelmoussaoui commented 9 years ago

They're used in Geary, you can find the list of icons here Apps/Geary/SymbolicIcons - GNOME Wiki!

palob commented 9 years ago

Which variant do you prefer for the Pantheon Photos action icons?

Big icons: adw_bright_big adw_dark_big Slightly smaller icons: adw_bright_small adw_dark_small

bilelmoussaoui commented 9 years ago

Big ones looks good to me!

dirtydancing commented 9 years ago

Yeah, the big ones fit better imo as well.

Foggalong commented 9 years ago

Yeah, big is fine with me :)

palob commented 9 years ago

I'm at a loss for

mail-archive mail-mailbox

Looking this way in the elementary theme: mail-archive-24 mail-mailbox

palob commented 9 years ago

The above icons are amongst the last polychrome icons used in elementary icons. The remaining icons are actions icons for applications like Inkscape, symbolic action and status icons, cursors.

Regarding the 16px symbolic icons the sheer amount aside I think it may be difficult to design each one in a distinct Numix way.

As far as I can see some icons in .../scalable/actions are copied over from an older version of gnome or Adwaita, maybe for this reason.

Is there anything objectionable to adding elementary (and Breeze) to the inheritance line? It would improve the situation right now as in case of missing Numix icons at least the original icons show up instead of a blank space or a ? icon.