search

numixproject / numix-icon-theme

Official base icon theme from the Numix project.
http://numixproject.github.io
GNU General Public License v3.0
778 stars 87 forks source link

Small monochrome icons in Gnome shell #485

Closed Foggalong closed 1 year ago

Foggalong commented 9 years ago

Original brought to my attention in this issue in the Moka icon theme.

Starting with Gnome 3.16, Gnome shell shows small monochrome icons in the top panel. These Icons are available with the default applications of Gnome but other apps are missing these icons. Would you please consider adding these monochrome icons to your icons.

One that uses it: 51d89ede-f74d-11e4-8eae-c150a1d06162

One that doesn't: 69054ae4-f74d-11e4-85ac-d3e1c5b99d18

If you provide *-symbolic.svg icons in scalable/apps/ folder, Gnome shell will use those icons.

We should probably talk about what we want to do about this. Some points to discuss:

dirtydancing commented 9 years ago

Just sharing another observation, as we have been wondering about the inheritances and that these symbolic-named app icons are also picked up when e.g. gnome icon theme is not in the inheritance line:

In continuation of my comment over at https://github.com/numixproject/numix-icon-theme/pull/537#issuecomment-110699860, my observations so far have confirmed that apparently there are two layers of inheritances: one as specified in the icon them itself, and one as specified by the "implementation".

For GNOME, I have noticed that the "implementation" appears to encompass the inheritances default and hicolor. This would lead to the following inheritance line e.g. for Numix-Circle: Numix-Circle > Numix > gnome > hicolor > default (Adwaita) > hicolor. This shows that actually removing the inheritance line in Numix might lead to a "cleaner" inheritance line for the respective DE. Without the inheritance line gnome,hicolor in Numix base, the inheritance line in Numix-Circle would look like this: Numix-Circle > Numix > Adwaita (implementation default) > hicolor (implementation fallback). I have done some testing, and at least for Arch/GNOME this seems to be the case. I cannot say whether this kind of "failsave" works everywhere, but this would e.g. ensure that hicolor is always the "fallback" icon theme.

For this issue, this would mean that, as observed, changing the inheritance line would not change anything about the *-symbolic.svg icons being displayed as active app icon in the GNOME Shell panel.

palob commented 9 years ago

@rockon999 made a GNOME Shell extension which successfully turns off the symbolic icons: https://github.com/rockon999/appmenu-regular-icons https://extensions.gnome.org/extension/970/appmenu-regular-icons/

In case somebody wants to restore the pre-3.16 behaviour those are the relevant commits: commit 1, GNOME git commit 2, GNOME git

commit 1, GitHub mirror commit 2, GitHub mirror

dirtydancing commented 9 years ago

Confirmed that the extension works on Arch/GNOME, thanks @rockon999 :+1: This way, there is no need anymore to manually edit the gnome shell configuration (cf. above), if one does not want to do that.

This means that by now, there is an extension to hide the active app icons altogether and an extension to always display the regular (non-symbolic) icons.

Still, this means that out of the box, the GNOME Shell active app icons will be non-consistently symbolic and only/mostly regular when there is no *-symbolic.svg app icon available.

Relating to the present issue: I still do not see a proper way on how to address this issue from Numix's side short of designing ~ 1500 symbolic app icons (cf. above).

In conclusion, imo for now this issue should be a won't fix.

palob commented 9 years ago

Plus I think in many cases it's not even possible to design 16 px symbolic icons distinctly "Numixy".

bilelmoussaoui commented 8 years ago

I'm using Gnome and i really don't like those icons, first thing i do on a fresh install is using an extension to disable them. There's a lot of applications that deserves to get a Numix theme more than those icons; We will need to add Adwaita as a fallback theme?

dirtydancing commented 8 years ago

@bil-elmoussaoui I am not sure what you are saying here :) The active app icons in the GNOME top bar are showing up per default. I am not sure what this issue has to do with adding Adwaita as a fallback icon theme?

Foggalong commented 8 years ago

I believe GNOME will be removing these icons either in the next or next over version. I'm sure I saw something about it on WoG a few weeks ago

andia89 commented 8 years ago

At least they realize there bad ideas...

bilelmoussaoui commented 7 years ago

@Foggalong Just a quick update, sadly it seems to not be the case. Gnome 3.24 will be forcing the notification center to use Symbolic icons.... I don't think they will ever be removed :( at least not in the near future!

palob commented 7 years ago

Does this mean this https://extensions.gnome.org/extension/970/appmenu-regular-icons/ will cease to work as well?

bilelmoussaoui commented 7 years ago

It will work, but as i've said, the notification center will always try to use symbolic icons instead of normal ones; We will wait until an other workaround (extension) done by someone ...

ewlsh commented 7 years ago

I'll look into this, don't worry. I'll ensure that the extension works on 3.24 (or develop a new one).

ewlsh commented 7 years ago

Okay, I've looked over the Gnome Shell changes and the current App Menu code can be fairly easily cross-applied. For 3.24 I'm going to create a 'Regular Icons' or 'Icon Mode Changer' extension that applies to all relevant Gnome Shell UI elements. I'll discontinue 'AppMenu Regular Icons' at that point and only guarantee bug fixes for it as Debian Stable will probably use 3.22 for the next five years (or so).

P.S. The rewrite for Gnome 3.22 has been actually uploaded to Gnome Extensions and is pending review. May have forgotten to do that earlier...

palob commented 7 years ago

It works anyway.

Foggalong commented 7 years ago

@bil-elmoussaoui @palob Is the current state of GNOME going forward then that these are to be included?

bilelmoussaoui commented 7 years ago

@Foggalong GNOME is now using symbolic icons on notifications (if possible), also on the notification center.

Foggalong commented 7 years ago

@bil-elmoussaoui What's the fallback theme like / what happens if an app doesn't have an appropriate icon in the fallback theme?

bilelmoussaoui commented 7 years ago

@Foggalong The normal icon is used instead just like with the running instance of the application :)

Foggalong commented 7 years ago

@bil-elmoussaoui Well damn, so it's inconsistent unless we provide icons for everything? :O

bilelmoussaoui commented 7 years ago

Yeah :/ I propose to keep this open for now, and concentrate on fixing "most" important and wanted stuff :)

ewlsh commented 7 years ago

Arch finally got 3.24 and I finally had some free time :) If anyone could test out the new extension I'd be grateful. No Symbolic Icons also has preferences that allow you to select where you want symbolic icons to be removed from.

Link to 'No Symbolic Icons'

palob commented 7 years ago

So far it works without any hiccups. However the notifications icon size now is 16px. Back then it used to be 48px.

Imerion commented 7 years ago

Brilliant! Thanks for creating this extension. :D

palob commented 1 year ago

Calling this a wontfix. There is no room for a Numixy design in symbolic icons. Let's just inherit from Adwaita.