numixproject / numix-icon-theme

Official base icon theme from the Numix project.
http://numixproject.github.io
GNU General Public License v3.0
779 stars 87 forks source link

Missing icons from Adwaita theme #577

Closed andia89 closed 1 year ago

andia89 commented 9 years ago

Since there is the same issue report for Elementary freya #437 I figured I might as well file a bug report for all mising icons in the Adwaita theme (the new default icon theme for gtk 3+). There are actually not that much icons.

dirtydancing commented 9 years ago

@wa4557 network-wired-acquiring-symbolic.svg has been added, cf. https://github.com/numixproject/numix-icon-theme/issues/570, https://github.com/numixproject/numix-icon-theme/pull/571.

andia89 commented 9 years ago

are all of those -symolic icons related to #485?

dirtydancing commented 9 years ago

No, not at all. I have not checked in detail, but https://github.com/numixproject/numix-icon-theme/issues/485 is mainly related to app icons with an added -symbolic name. Also, several of those icons over from https://github.com/numixproject/numix-icon-theme/issues/485 are located in hicolor and not in gnome/Adwaita, but apparently also this differs in detail depending on the respective distro.

dirtydancing commented 9 years ago

@wa4557 When looking into the harddisk icons, I have noted that e.g. drive-harddisk-solidstate-symbolic (in scalable/devices) is missing from the list.

What is the reference source for the list? An overview of the icons in current adwaita-icon-theme 3.16.2.1 can be found e.g. at https://www.archlinux.org/packages/extra/any/adwaita-icon-theme/ (file list link below "Package Contents").

andia89 commented 9 years ago

@dirtydancing I used the ubuntu package as reference, which seems to be outdated. I changed that accordingly

dirtydancing commented 9 years ago

Great! I have also noticed that e.g. battery-symbolic was not on the list before, and now it is :+1:

dirtydancing commented 9 years ago

For the time being, I would like to suggest to strike out the (36) icons in scalable/apps, as these appear to be among the ones that are being dealt with in https://github.com/numixproject/numix-icon-theme/issues/485. In the end, they might not be included at all:

usr/share/icons/Adwaita/scalable/apps/accessories-calculator-symbolic.svg usr/share/icons/Adwaita/scalable/apps/accessories-character-map-symbolic.svg usr/share/icons/Adwaita/scalable/apps/accessories-dictionary-symbolic.svg usr/share/icons/Adwaita/scalable/apps/accessories-text-editor-symbolic.svg usr/share/icons/Adwaita/scalable/apps/applets-screenshooter-symbolic.svg usr/share/icons/Adwaita/scalable/apps/bluetooth-symbolic.svg usr/share/icons/Adwaita/scalable/apps/gnome-power-manager-symbolic.svg usr/share/icons/Adwaita/scalable/apps/goa-panel-symbolic.svg usr/share/icons/Adwaita/scalable/apps/help-browser-symbolic.svg usr/share/icons/Adwaita/scalable/apps/help-contents-symbolic.svg usr/share/icons/Adwaita/scalable/apps/help-faq-symbolic.svg usr/share/icons/Adwaita/scalable/apps/multimedia-volume-control-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-color-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-accessibility-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-display-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-font-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-keyboard-shortcuts-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-locale-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-remote-desktop-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-screensaver-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-desktop-wallpaper-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-system-network-proxy-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-system-network-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-system-notifications-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-system-privacy-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-system-search-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-system-sharing-symbolic.svg usr/share/icons/Adwaita/scalable/apps/preferences-system-time-symbolic.svg usr/share/icons/Adwaita/scalable/apps/system-file-manager-symbolic.svg usr/share/icons/Adwaita/scalable/apps/system-software-install-symbolic.svg usr/share/icons/Adwaita/scalable/apps/system-users-symbolic.svg usr/share/icons/Adwaita/scalable/apps/text-editor-symbolic.svg usr/share/icons/Adwaita/scalable/apps/user-info-symbolic.svg usr/share/icons/Adwaita/scalable/apps/utilities-system-monitor-symbolic.svg usr/share/icons/Adwaita/scalable/apps/utilities-terminal-symbolic.svg usr/share/icons/Adwaita/scalable/apps/web-browser-symbolic.svg

andia89 commented 9 years ago

Makes sense. I'll do it a little ater

dirtydancing commented 9 years ago

Ah, it looks like you removed the icons from scalable/apps. This is not what I meant. I would still suggest to leave them listed and to just strike them out, like e.g. the "GitHub folder" in this list over at numix-folders: https://github.com/numixproject/numix-folders/issues/78. This way, they will still be visible and can still be cross-checked e.g. with https://github.com/numixproject/numix-icon-theme/issues/485.

Moverover: would it be possible to bring back the couple of icons that were added since you created the list, just like before? That way, at least some of all these icons can be seen as added, looks more motivating :)

The icon names were:

network-wired-acquiring-symbolic, cf. https://github.com/numixproject/numix-icon-theme/issues/570 battery-symbolic, cf. https://github.com/numixproject/numix-icon-theme/issues/581 drive-harddisk-ieee1394-symbolic, drive-harddisk-system-symbolic, drive-harddisk-usb-symbolic, cf. https://github.com/numixproject/numix-icon-theme/issues/583 drive-harddisk-solidstate-symbolic, cf. https://github.com/numixproject/numix-icon-theme/issues/585

Cheers! I am hopeful that the list management will not turn into too much of an issue in and of itself :)

andia89 commented 9 years ago

I think the lists are long enough as is, so I think it's a better idea to remove the finished icons from time to time :)

dirtydancing commented 9 years ago

Fair enough :) And imo your call, as you are managing this list. No need to create unnecessary work.

dirtydancing commented 9 years ago

@wa4557 So, after the PSA from @Foggalong from over here, https://github.com/numixproject/numix-icon-theme/issues/437#issuecomment-113192513, are you going to re-include the icons I listed above with a check mark? :) That would indeed make it easier to track things.

hlechner commented 9 years ago

application/x-firmware reported also in #566

andia89 commented 9 years ago

For all those symbolic icons: Would it be ok to just use the icons from Adwaita and modify them slightly so that they fit the numix design (I guess that's what happened with most of the scalable icons currently present in the theme)

dirtydancing commented 9 years ago

Well, I cannot confirm that all the Numix scalable symbolic icons, e.g. in devices and status, are slight modifications of Adwaita. Adwaita is very good in these imo, though, and so does not really crash with the Numix icons. Anyways, with my use of Arch/GNOME, I do not run into that many Adwaita icons at all.

Foggalong commented 9 years ago

Regarding the symbolic icons, no. afaik the Numix symbolic icons (mostly designed by @me4oslav) are of Numix design, not an Adwaita one.

andia89 commented 9 years ago

I politely disagree, but that's not true. Most of the icons in scalable/devices and scalable/actions are from the adwaita theme, the icons from scalable/status are mostly original however, that's true

dirtydancing commented 9 years ago

To me, there seems to be an overlap but also differing icons/icon names in scalable/actions, but there seem to be distinguished Numix icons in scalable/categories, scalable/devices, scalable/emblems, scalable/mimetypes, scalable/places and scalable/status. I am not sure why there are still coloured non-symbolic named icons in scalable/apps.

palob commented 9 years ago

I think a few icons are older-revision Adwaita icons.

bilelmoussaoui commented 9 years ago

@Foggalong @wa4557 a lot of symbolic icons were in added in the latest pull request! i think they should be ticked :+1:

andia89 commented 9 years ago

done, still more than 200 icons :)

Foggalong commented 9 years ago

:+1:

bilelmoussaoui commented 8 years ago

@wa4557 network-wireless-offline-symbolic already exists

bilelmoussaoui commented 8 years ago

@wa4557 @Foggalong Those icons can be ticked from the list :p

andia89 commented 8 years ago

@bil-elmoussaoui Done

bilelmoussaoui commented 8 years ago

@wa4557 Those ones too

palob commented 1 year ago

My stance on symbolic icons is we should just inherit the Adwaita ones. There is no way to implement a Numixy design anyway.

palob commented 1 year ago

Closing this because GNOME apps don't use the non-symbolic icons anymore. The few icons missing here for completion probably won't be used in any app anyway.