Battery Status Icon Xfce-Power-Manager 1.5.x

[ragazenta]

After installing new xfce-power-manager 1.5.2, battery icon in panel was changed.

I found that non -symbolic filename suffix is needed. Those files were deleted #236.

battery-caution-charging.svg
battery-caution.svg
battery-empty-charging.svg
battery-empty.svg
battery-full-charged.svg
battery-full-charging.svg
battery-full.svg
battery-good-charging.svg
battery-good.svg
battery-low-charging.svg
battery-low.svg 

I tried restoring files above in 24x24 directory, it works for me now.

[andia89]

@dirtydancing Will this break a lot?

[Foggalong]

Is v1.5.2 the version in 15.10?

[dirtydancing]

Woah, this sounds like breakage to me! I am not sure what though, will have to think about this.

For starters, I would like to clarify that not all of these icons have not been deleted, only battery-caution and battery-low. The others were never part of the battery status icons. These have simply not been used in the panel by any distro/DE/shell so far. For a current overview of the battery status icons, cf. https://github.com/numixproject/numix-icon-theme/issues/107#issuecomment-98399311.

@ragazenta What do you mean with "restoring files"?

[ragazenta]

@Foggalong I dunno, I'm not using Ubuntu.

@dirtydancing Those files above I mentioned were missing in 24x24 directory. I followed battery-*-symbolic.svg link and created same link without -symbolic suffix.

xfce-power-manager (xpm) 1.5.x (marked as stable) maybe not been used in panel by most distro so far, I am using Gentoo, dzen + trayer-srg as panel. I updated xpm few days ago. Before xpm 1.5.x, everything was fine. Just curious why battery icon was changed.

[dirtydancing]

So far, for the panel battery status icons there have been either percentage-named non-symbolic-named icons or status-named symbolic-named icons (esp. for GNOME shell).

Now, apparently we have a new kid on the panel block: status-named non-symbolic-named icons. These kind of icons so far are used e.g. in Ubuntu for non-panel purposes. Currently they exist in sizes 32 and 48 in devices, so adding them to (16,22) 24 in status might cause non-panel breakage. In addition, adding them to (16,22) 24 in status might also cause panel breakage elsewhere.

[dirtydancing]

Platform	Version	Link
Arch	1.4.4	link
AUR	1.5.2	link
Gentoo	1.5.2	-
Ubuntu	1.4.4.	link

[andia89]

At least in Ubuntu there seems to be no problem when adding those icons. The devices icons are still used where they should be (power managment preferences)

[Foggalong]

(@dirtydancing I edited that comment to try and keep this clean as possible. I'm well aware that battery issues tend to get very long very fast so gonna try and keep this one as readable as possible)

[dirtydancing]

Is this the relevant icon overview? http://git.xfce.org/xfce/xfce4-power-manager/tree/data/icons/scalable

That one includes symbolic-named as well as non-symbolic-named icons, both in scalable. I have checked, and the symbolic-named icons are the GNOME/Adwaita status icons, and those should be displayed in the panel.

At the moment, I am not quite sure what to make of this. This could mean that xpm 1.5 is following the GNOME/Adwaita icons, but for some reason is looking at fixed size 24 specifically (and then also at 32 or 48) before looking into scalable (?).

@ragazenta Could you check if the panel battery status icons are fine when you delete the icons (same icon names that you listed) that are currently located in sizes 32 and 48 in devices?

[dirtydancing]

@ragazenta Could you also check which battery status icons are displayed in the panel with the default (Adwaita?) icon theme.

[dirtydancing]

@wa4557 Good to hear that adding those icons does not cause any damage in Ubuntu. Where did you add them (fixed size or scalable)?

Before adding these icons and waiting for any bug reports (given the complexity of getting these icons to work on all distros, that might make sense), we should make sure that this is not a bug somewhere else.

[ragazenta]

@dirtydancing Yes. I have xpm tarball source, same as that git.xfce link.

I deleted icons you mentioned

Battery icon is changed

If using Adwaita

[dirtydancing]

This is strange. To me, this looks like something is wrong with the icons in xfce4-power-manager 1.5. Apparently, there are symbolic-named icons in scalable, which should be used in the panel, but they are not. This is demonstrated by your second screenshot using Adwaita.

And the first screenshot demonstrates that even if Numix does not contain the non-symbolic named icons, not the proper symbolic-named icons in Numix are used, but rather the non-symbolic named icons in GNOME/Adwaita (inherited or fallback icon theme).

At the moment, I am not sure what to make of this. Any ideas?

[dirtydancing]

@ragazenta Judging from your first screenshot above and from the very first screenshot at the top, apparently your panel is not using icons from the scalable directory, but rather from the fixed size directories, and from the fixed size directories exclusively. The network icon is not from scalable, either. So this might be an issue with the panel, or more precisely an issue with the panel in combination with xpm 1.5. Just speculating here.

[andia89]

I'd argue that we can add those icons. They are not used by any other distro in the panel (if that would be the case they would have been added sooner), and the reason why we added those icons to devices were the ubuntu power preferences, and adding those icons to 16/22/24 does not break anything there

[dirtydancing]

@wa4557 You are probably right, and adding those (symlinks) would probably not break any other distro in the panel. Still, something seems to be off with xpm 1.5: it does provide monochrome symbolic-named status icons (for the panel?), but for some reason xpm 1.5 (or the panel in this specific case?) insists on using non-monochrome non-symbolic-named icons in the panel, which xpm 1.5 provides in parallel.

[dirtydancing]

I came across this bit of info over at http://news.softpedia.com/news/Xfce-Power-Manager-1-5-0-Finally-Ported-to-GTK3-plus-482317.shtml "the panel plugin now uses UPower's icon names, symbolic icons are now used for the panel plugin, colored icons have been implemented for the systray icon".

@ragazenta Are you using the "panel plugin" (which should be using symbolic icons) for your panel?

[ragazenta]

@dirtydancing I'm not using panel plugin. I'm using trayer-syg, which is systray.

[dirtydancing]

Well, in this case, I would argue that there is no issue here, as with xpm 1.5 "colored icons have been implemented for the systray icon". So actually the correct icon is showing with Numix.

I would argue that we should not make any changes to the battery status icons at this point. In any event, it is good to be aware of this situation in case of further future issue reports.

[Foggalong]

Wait, I'm confused. The normal xpm uses the monochrome status icons, but you're using a systray which changes the icons to the device icons?

[dirtydancing]

As far as I can tell (not using xpm 1.5), systray in xpm 1.5 is implemented with "colored" icons, which in this context means non-monochrome non-symbolic-named status-named battery icons. In Numix base, those are located in devices, and they are looked up (as intended by xpm 1.5) due to their icon name.

[ragazenta]

Well, I agree about xpm implementation is the issue here. Before 1.5, battery icon systray was disabled. I couldn't show battery icon without panel plugin, so I downgraded it. Now in version 1.5, it has a feature to show/hide systray, but like @dirtydancing said, it's using colored (non-symbolic-named) icons.

I'll keep using the 'restored' version above. Thanks for the great icons.

[Foggalong]

@ragazenta Do you know if this has been fixed in the latest git version?

[ragazenta]

Yes, thanks.