Missing online accounts

[bilelmoussaoui]

There's a few missing online account icons for GOA and Feedreader

• [ ] feed-share-evernote
• [ ] feed-share-instapaper
• [ ] feed-share-pocket
• [ ] feed-share-readability
• [x] goa-account-foursquare
• [ ] goa-account (see #978)
• [ ] im-ekiga
• [ ] im-facebook -> facebook
• [ ] im-gadugadu
• [ ] im-gizmo
• [ ] im-google-talk
• [ ] im-groupwise
• [ ] im-icq
• [ ] im-irc
• [ ] im-local-xmpp
• [ ] im-meanwhile
• [ ] im-mxit
• [ ] im-myspace
• [ ] im-qq
• [ ] im-sametime
• [ ] im-silc
• [ ] im-sip
• [x] im-yahoo
• [ ] im-zephyr

[bilelmoussaoui]

Btw: im-jabber need to be removed from Numix Circle..

[andia89]

Google talk is EOL a long time ago...

[bilelmoussaoui]

@wa4557 i didn't knew that..i will remove it from the list

[andia89]

goa-account is it a good idea to have it transparent like in hicolor?

[Foggalong]

Google Talk might be EOL but a few programs still use that name when talking about hangouts. Pidgin is one, I wouldn't be surprised if GOA does the same

[bilelmoussaoui]

@Foggalong yeah, should i add the whole list of im-* icons? some of them are used by Pidgin too

[Foggalong]

Yeah, stick em all in :) if this is gonna be another list request it may as well be a complete one

[bilelmoussaoui]

@wa4557 Yeah, we can change that later if gnome changes the icon in the future @Foggalong Done

[Foggalong]

Thanks :+1: alphabetised and combined the lists. Local xmpp is gonna be a pain :(

[andia89]

@bil-elmoussaoui im-yahoo is already there

[bilelmoussaoui]

@wa4557 Done

[heyhippari]

I figured I'd mention it here instead of opening another issue, since it's related, but the mail-unread-symbolic icon not being centered looks weird in Online Accounts:

According to the GTK inspector, the array of icons is ["mail-unread-symbolic", "mail-symbolic", "mail-unread", "mail"].

[Foggalong]

@MrTimscampi Did you upload the wrong screenshot? I'm confused what you're referring to :/

[heyhippari]

@Foggalong That's a screenshot of the Onine Accounts page in Settings in Gnome 3.24.
The mail icon used for "IMAP and SMTP" isn't properly centered vertically, because it's using "mail-unread-symbolic".

I'm not sure of the order GTK tries to use the icons in the line I gave, but my guess is that currently it uses "mail-unread-symbolic" because nothing else is available ? The most sense would be to make a "mail" icon that would (hopefully) take precedence on that non-centered one.

I can try locally and make a commit using a symlink to "mail-message" if you want ?

Edit: After testing and looking at the documentation, my first hunch was right and it's using "mail-unread-symbolic" because it's the first one in the array. Imho, it would make more sense style-wise if Gnome used the array in the other direction, with "mail" taking priority.
Should I submit a centered version of mail-unread-symbolic ? It had no specific markings compared to the normal mail icon anyway, aside from being off-center (The colored version has a star added)

[Foggalong]

@MrTimscampi I spent the entire time looking at horizontal alignment, didn't even notice the vertical alignment was out of wack. My back!