numo-labs / aws-lambda-helper

:lollipop: Collection of helper methods for lambda
GNU General Public License v3.0
22 stars 2 forks source link

Cleanup #11

Closed plaenen closed 8 years ago

plaenen commented 8 years ago

@nelsonic

could you review the pull-request?

nelsonic commented 8 years ago

This certainly is a simplification. :+1: The mock you have written is easier to understand. Our main idea behind using aws-sdk-mock was to keep the mocks consistent, If we expand the helper to more AWS services it may get tedious to write/maintain mocks for each one. But for now this works well.

nelsonic commented 8 years ago

@jruts observed that we don't need the config Object so we will remove it before merging.

plaenen commented 8 years ago

config removed. @nelsonic @jruts @nikhilaravi can you take a look?

you should be able when merging to completely use my files

plaenen commented 8 years ago

@nikhilaravi, error message changed as recommended

nikhilaravi commented 8 years ago

@plaenen the changes look great!! :smile: