numo-labs / aws-lambda-helper

:lollipop: Collection of helper methods for lambda
GNU General Public License v3.0
22 stars 2 forks source link

Moving `aws-sdk` to a production dependency #30

Closed tomgco closed 8 years ago

tomgco commented 8 years ago

aws-sdk should be listed as a production dependency instead of a development dependency.

codecov-io commented 8 years ago

Current coverage is 100%

Merging #30 into master will increase coverage by +n/a%

@@           master   #30   diff @@
===================================
  Files           1     1          
  Lines          76    76          
  Methods         0     0          
  Branches        0     0          
===================================
  Hits           76    76          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last updated by c7d55f5...8d17cf8

nelsonic commented 8 years ago

@tomgco the aws-sdk is available in every lambda. see: "Available Libraries" : http://docs.aws.amazon.com/lambda/latest/dg/current-supported-versions.html (so we should not need to bundle it with our lambdas...)

tomgco commented 8 years ago

@tomgco the aws-sdk is available in every lambda. see: "Available Libraries" : http://docs.aws.amazon.com/lambda/latest/dg/current-supported-versions.html (so we should not need to bundle it with our lambdas...)

Hmm, ok. I now understand why it is listed as a development library, although still seems a bit too magical to me. I will close this anyway as it is the Lambda way of doing it, it seems.

nelsonic commented 8 years ago

Yeah, its just something that "always available" at the container level ... go with it. 😉 (strictly speaking we should list all our Prod dependencies explicitly, I agree 100%)