Closed tomgco closed 8 years ago
Merging #32 into master will not change coverage
- File
lib/index.js
was modified. more
- Misses
0
- Partials
0
- Hits
+36
@@ master #32 diff @@
===================================
Files 1 1
Lines 102 147 +45
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 102 147 +45
Misses 0 0
Partials 0 0
Powered by Codecov. Last updated by a921d51...586abbc
@nelsonic @jruts Would you mind casting your eyes over this?
@tomgco looks good. are you making any further changes e.g. usage example in readme? or can we merge?
@tomgco looks good. are you making any further changes e.g. usage example in readme? or can we merge?
@nelsonic I have just rebased and simplified some logic based on the other PR that has merged (and also a documentation fix). Everything around usage is documented sufficiently, however around the architecture I will update https://github.com/numo-labs/inspirational-search-docs with all of the required information.
So LGTM; and ready to merge.
@tomgco cool. agree. merging. 👍
This will forward the trace-request-id to the invoked lambda if present in the original event.
This is being patched in for now to maintain backwards compatibility, however eventually I would like to move all of our Payloads to a format like:
However as it currently the headers attribute is being re-assigned to a new object.