search

numo-labs / aws-lambda-helper

:lollipop: Collection of helper methods for lambda
GNU General Public License v3.0
22 stars 2 forks source link

S3url #55

Closed nelsonic closed 8 years ago

nelsonic commented 8 years ago

Remove http POST to /data for WebSockets. Using SNS + Redis PubSub exclusively.

lennym commented 8 years ago

Looks ok to me, but I'd probably want to rename pushToSocketServer.js to something more relevant now.

codecov-io commented 8 years ago

Current coverage is 100%

Merging #55 into master will not change coverage

@@             master        #55   diff @@
==========================================
  Files             1          1          
  Lines           190        152    -38   
  Methods          34         27     -7   
  Messages          0          0          
  Branches         35         29     -6   
==========================================
- Hits            190        152    -38   
  Misses            0          0          
  Partials          0          0

Sunburst

Powered by Codecov. Last updated by ce5c909...3c33436

nelsonic commented 8 years ago

This PR is ready to ship. I asked a question in the discussion: https://github.com/numo-labs/aws-lambda-helper/issues/54#issuecomment-222199596 which could lead to a further change, but if we just want to get the new version without HTTP POST /data published, this can be merged and deployed. 👍

tomgco commented 8 years ago

This PR should've been a Major version bump, as we are removing failOnError