search

numo-labs / isearch-ui

:yellow_heart: :mag: The ui for inspirational search!
GNU General Public License v3.0
7 stars 7 forks source link

Revert "Revert "IE style"" #345

Closed Kumjami closed 8 years ago

Kumjami commented 8 years ago

Reverts numo-labs/isearch-ui#343

Kumjami commented 8 years ago

From: image

To: image

tomgco commented 8 years ago

LGTM!

On a side note @nelsonic it would be awesome to have a source labs bot that did this to our PR's :D

nelsonic commented 8 years ago

@tomgco agreed. 👍

lennym commented 8 years ago

https://github.com/Huddle/PhantomCSS would probably work as part of the codeship build, but would potentially be completely blown apart by the randomised background images.

nelsonic commented 8 years ago

@lennym yeah, that could be a good option, but as you say background images would be an initial obstacle...

lennym commented 8 years ago

It looks like it has an option to hide certain selectors before making a comparison, which should help. I'll take a look into it.

tomgco commented 8 years ago

It looks like it has an option to hide certain selectors before making a comparison, which should help. I'll take a look into it.

Cool, that would be sweet.

nelsonic commented 8 years ago

@lennym did a spike to investigate using https://github.com/Huddle/PhantomCSS ... phantomcss-regression-testing-conclusion