numo-labs / isearch-ui

:yellow_heart: :mag: The ui for inspirational search!
GNU General Public License v3.0
7 stars 7 forks source link

Autocompletefocus #395

Closed Kumjami closed 8 years ago

Kumjami commented 8 years ago

On focus: image

When there is no results:

image

On hover:

image

When text is more than one line (working on that):

image

lennym commented 8 years ago

I've found a little UI bug in the search box that I'm just looking into on master before reporting.

Then search box becomes unresponsive to typing, and assorted javascript errors are displayed in console.

Edit: this works fine on master, and is reproducible on this branch with the steps above.

lennym commented 8 years ago

It might be cool now we're collecting data to use our analytics/ranking services to provide the actual most popular tags too rather than a hardcoded list.

tomgco commented 8 years ago

It might be cool now we're collecting data to use our analytics/ranking services to provide the actual most popular tags too rather than a hardcoded list.

Let's get this merged first :D

tomgco commented 8 years ago

I've found a little UI bug in the search box that I'm just looking into on master before reporting.

Search for a tag Click reset Type in search box Then search box becomes unresponsive to typing, and assorted javascript errors are displayed in console.

Edit: this works fine on master, and is reproducible on this branch with the steps above.

@Kumjami Can you reproduce and fix the following bug, once done we can merge this in :]

Kumjami commented 8 years ago

@tomgco Working on it, actually this concrete bug is fixed but I want to improve a little bit user experience.

While searching for something, the previous suggestions are there to the onfocus, and other details

lennym commented 8 years ago

@tomgco I agree.

Kumjami commented 8 years ago

@lennym @tomgco review/merge pls thanks

tomgco commented 8 years ago

@Kumjami Isn't this merging into the wrong branch?

Kumjami wants to merge 6 commits into autosuggestDefault from autocompletefocus

Kumjami commented 8 years ago

this would be merge to @jackcarlisle branch, and then @jackcarlisle branch could be merge to master this branch was created from @jackcarlisleĀ“s one