search

numo-labs / isearch-ui

:yellow_heart: :mag: The ui for inspirational search!
GNU General Public License v3.0
7 stars 7 forks source link

Analytics Undefined destinationName #494

Closed Kumjami closed 8 years ago

Kumjami commented 8 years ago

To ensure a full fix for the issue being opened can you please provide:

image

Expected Behaviour

DestinationName should have the human friendly destination name code.

Actual Behaviour

DestinationName is equal to the string undefined

Further Information

This is being received directly from the back-end as a string with value undefined

tomgco commented 8 years ago

s/undefined/unavailable/

This isn't a bug but intended behaviour for when a provider does not have a destination name. This is up to the analytics team to decide what information they wish to receive instead.

Kumjami commented 8 years ago

@tomgco Yes tom, removing bug flag, but letting it here just not to forget

tomgco commented 8 years ago

From slack: 

ok then! No biggie! I was not aware of that. From an analytics perspective it is not a big deal, we can use detination code instead, which is actually available