numo-labs / lambda-ne-classic-package-provider

:sunrise: A lambda function that listens to an SNS topic, makes a call to the price and availability cache API and then adds the results to a corresponding search bucket
2 stars 0 forks source link

Package tiles extra data #103

Closed Kumjami closed 8 years ago

Kumjami commented 8 years ago

In order to have at front end the required data for analytics it's needed to add destinationCode, destinationName and departureCode.

Missing dimensions in hotel product objects

We want to send the "custom" dimensions (11,12,13) in all ecommerce actions (impressions, clicks, detailed viewed, add-to- carts). This is currently only done for "add-to- carts" i.e., when the user makes a click-through from an expanded hotel tile to the Spies site. See the measurement plan for details. Source

nelsonic commented 8 years ago

@Kumjami do we send an impression to DataLayer with all these bits of data when the client is viewing the search results?

codecov-io commented 8 years ago

Current coverage is 97.89%

Merging #103 into master will not change coverage

@@             master       #103   diff @@
==========================================
  Files             6          6          
  Lines           238        238          
  Methods          44         44          
  Messages          0          0          
  Branches         35         35          
==========================================
  Hits            233        233          
  Misses            5          5          
  Partials          0          0          

Powered by Codecov. Last updated by 577eb11...c981c53

nelsonic commented 8 years ago

Merging so you can continue your Analytics work. 👍