search

numo-labs / lambda-ne-classic-package-provider

:sunrise: A lambda function that listens to an SNS topic, makes a call to the price and availability cache API and then adds the results to a corresponding search bucket
2 stars 0 forks source link

Send Hotel Id to Client so we can pass it through to Analytics (Kinesis) ? #108

Closed nelsonic closed 8 years ago

nelsonic commented 8 years ago

Last week we discussed what data we want to send in events to Kinesis, At present we're constructing the id of each package by combining result.destinationCode + result.hotelCode see: https://github.com/numo-labs/lambda-ne-classic-package-provider/blob/8fc08051ba1bdffbaaba8d581838ddfc493a4d6f/lib/result_mapper.js#L114

We discussed using the wvId instead which would allow us to weight the hotels returned by Neo4J based on the number of clicks ...

@tomgco / @lennym is this still the plan?

tomgco commented 8 years ago

@nelsonic It certainly is :]

nelsonic commented 8 years ago

@tomgco should we name the property package.hotelid or re-purpose package.id ?

tomgco commented 8 years ago

@nelsonic I have been working on this issue at: https://github.com/numo-labs/lambda-ne-dynamic-package-provider/pull/1 and https://github.com/numo-labs/lambda-ne-classic-package-provider/pull/109

nelsonic commented 8 years ago

Updated by @tomgco : https://github.com/numo-labs/lambda-ne-classic-package-provider/commit/2e2ad45ca954c7280015f17c8af883bfe40686f1