Bugfix/type error - Githubissues

numo-labs / lambda-ne-classic-package-provider

:sunrise: A lambda function that listens to an SNS topic, makes a call to the price and availability cache API and then adds the results to a corresponding search bucket

2 stars 0 forks source link

Bugfix/type error #90

Closed nelsonic closed 8 years ago

nelsonic commented 8 years ago

Hi @jruts this PR fixes the 3 issues noted today.

fixes #86 - when a hotel does not have any images
fixes #87 - when the UI does not pass through any passengers
fixes #88 - avoid sending the hotelIds (can be a large list) to SNS topic.

Please review and let me know if Ok. thanks.

jruts commented 8 years ago

@nelsonic fix #89 is working since we are getting packages back in the ui.

nelsonic commented 8 years ago

@jruts yeah, you are 100% correct. I referenced the incorrect issue. should have been: https://github.com/numo-labs/lambda-ne-classic-package-provider/issues/88 Thanks!

jruts commented 8 years ago

:+1:

jruts commented 8 years ago

I am going to wait because I feel you have an improvement.

codecov-io commented 8 years ago

Current coverage is 100%

Merging #90 into master will not change coverage

@@             master        #90   diff @@
==========================================
  Files             6          6          
  Lines           243        248     +5   
  Methods          51         50     -1   
  Messages          0          0          
  Branches         31         35     +4   
==========================================
+ Hits            243        248     +5   
  Misses            0          0          
  Partials          0          0

Powered by Codecov. Last updated by 8968f89...d6aed99