numpy / numpy-stubs

Experimental typing stubs for NumPy
BSD 3-Clause "New" or "Revised" License
282 stars 32 forks source link

WiP: Added type annotations for the ``np.core.fromnumeric`` module #59

Closed BvB93 closed 4 years ago

BvB93 commented 4 years ago

See https://github.com/numpy/numpy-stubs/issues/54.

Introduced type hints for all (public) functions from the np.core.fromnumeric module.

Note that typing_extensions has also been added as a dependency for Python version prior to 3.8. See https://github.com/numpy/numpy-stubs/pull/63.

Functions

To do

person142 commented 4 years ago

Note that typing_extensions has also been added as a dependency for Python version prior to 3.8.

This should be fine, but let me open an issue to give people a chance to object.

person142 commented 4 years ago

@BvB93 actually would you mind making a separate PR just to add typing_extensions? Assuming no objections on https://github.com/numpy/numpy-stubs/issues/60 (unlikely I think) we can get it in asap-there have been a number of places where it would be useful.

BvB93 commented 4 years ago

No problem, I've just created the pull request at https://github.com/numpy/numpy-stubs/pull/63.

person142 commented 4 years ago

I see that the diff here has become quite large-I would appreciate it if you could split this into several smaller PRs. (At the end of a work day it's easier to motivate myself to review small pieces of code.)

BvB93 commented 4 years ago

No problem, I'll create a new (smaller) pull request later today with the first set of changes.