search

numpy / numpy-stubs

Experimental typing stubs for NumPy
BSD 3-Clause "New" or "Revised" License
282 stars 32 forks source link

TST: also run the code in "pass" #70

Closed person142 closed 4 years ago

person142 commented 4 years ago

It seems fair that the code in pass should also run; i.e. that directory shouldn't contain mypy false positives. Add a test that runs the modules in that directory and fix the resulting runtime errors.

person142 commented 4 years ago

Some of the failures are expected in that they are places where the stubs are not yet good enough to catch the issue, but some of these might merit issues being opened.

Hm and CI is failing on Python 3.7 only; that's interesting.

person142 commented 4 years ago

Ok, on 3.7 CI was running NumPy 1.14.2 which is what was causing the failures. I went ahead and bumped the minimum version to 1.16.0; that still goes 3 releases back (soon to be 4), so should be fine I think.

person142 commented 4 years ago

Fixes for some of the things addressed in this PR have been merged now, so rebased to include them.

rgommers commented 4 years ago

Merged, thanks @person142