search

numpy / numpy-tutorials

NumPy tutorials & educational content in notebook format
https://numpy.org/numpy-tutorials/
Other
447 stars 166 forks source link

Air pollution tutorial should show path to "vectorization" #152

Open seberg opened 1 year ago

seberg commented 1 year ago

The air polution tutorial has a "vectorized" function to calculte the AIQ (IIRC). This can be vectorized using searchsorted (which is a bit much work, but not too tricky). I am also almost completely certain that it can also be replaced with a single call to np.interp1d.

Having the "vectorize" version seems good, but doesn't fully leverage the concepts that NumPy provides. I think it would be great arc to keep it, but then also show the final interp and maybe even the searchsorted idea. (I honestly don't like stopping at vectorize becuzse it makes seems that vectorize is a common approach, when I consider it more of a fallback solution – whether used a lot in practice or not.)

ankur0904 commented 8 months ago

@rossbar I am working on this issue soon submit a PR.