numpy / numpy.org

The NumPy home page
http://numpy.org/
BSD 3-Clause "New" or "Revised" License
111 stars 106 forks source link

Refactor "Ecosystem/Scientific Domains" tab on front page #706

Closed alphapapa closed 10 months ago

alphapapa commented 10 months ago

This refactors the "Ecosystem/Scientific Domains" tab on the front page:

Please note that this PR depends on https://github.com/scientific-python/scientific-python-hugo-theme/pull/434. This PR should be merged to the numpy.org repo after that one is merged into the SPHT theme and the theme submodule is updated in the numpy.org repo accordingly. Until then, this PR will fail CI.

This PR should fix https://github.com/numpy/numpy.org/issues/705.

I don't have permissions on this repo to request reviewers or assign users, so: @stefanv @jarrodmillman

Screenshots

![localhost_1313_2](https://github.com/numpy/numpy.org/assets/601365/808910da-5b24-42c1-9e41-fe32bbf7487b) ![localhost_1313_](https://github.com/numpy/numpy.org/assets/601365/2e1ab96d-c3d3-4f76-97d8-a11d8bea5050)

netlify[bot] commented 10 months ago

Deploy Preview for numpy-org ready!

Name Link
Latest commit 0fee580cd8d00f65e7533d7c828d0a81fbcb7302
Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/657212bc9d1ff9000746a9b4
Deploy Preview https://deploy-preview-706--numpy-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stefanv commented 10 months ago

I merged https://github.com/scientific-python/scientific-python-hugo-theme/pull/434; sounds like you'll need to pin an updated theme.

The changes in this PR look good me, thanks!

stefanv commented 10 months ago

@alphapapa When you compare the width of the two renderings, the new one is much wider. Could you adjust it to look similar to what it was before?

alphapapa commented 10 months ago

@alphapapa When you compare the width of the two renderings, the new one is much wider. Could you adjust it to look similar to what it was before?

Sure, I'll work on that now. Thanks.

alphapapa commented 10 months ago

@stefanv This is much closer, almost pixel-perfect (getting to which might be counter-productive, since it's now using responsive design rather than the old tables):

Screenshots

Current numpy.org: ![numpy org_](https://github.com/numpy/numpy.org/assets/601365/a87da2de-2e5c-41a3-a052-86b6a57314f3) Current PR: ![localhost_1313_](https://github.com/numpy/numpy.org/assets/601365/43652bf1-ae91-45c6-b748-233b5edb5625)

stefanv commented 10 months ago

Thanks!