ENH: Reduce overhead of numpy.polynomial

[eendebakpt]

Proposed new feature or change:

The numpy.polynomial classes have quite some overhead in the calculations. This is a collection of ideas to reduce the overhead

• https://github.com/numpy/numpy/pull/24473
• https://github.com/numpy/numpy/pull/24467
• For several operations on polynomials (e.g. addition, substraction) the ABCPolyBase._get_coefficients takes time. The check np.all(self.domain == other.domain) can be replaced with either np.array_equal(self.domain, other.domain).all() or (self.domain == other.domain).all() (and similar for the window). For benchmark

from numpy.polynomial import Polynomial
import timeit

p = Polynomial([1,2,3])
q = Polynomial([3,2,1])

dt=timeit.timeit('p + p - q', globals={'p': p, 'q': q}, number=40_000)
print(dt)

the timings are

2.51 seconds (main)
2.35 seconds (np.array_equal)
2.2 seconds (.all() )

The fastest option does assume the domain already is a numpy array. Current main and the np.array_equal option cast (with asarray). https://github.com/numpy/numpy/pull/24499

• The numpy.polynomial.polyutils.as_series is called in many places. Also in internal methods where many of the input checks (e.g. on input dimensions) are not required. We can add a flag internal : bool to as_series than will skip several of the checks. Draft PR: #24531

Profiling results on main (2023-8-22) for p * q with p=Polynomial([1,2,3]); q=Polynomial([3,0,3]):

[aijams]

Hello, I would like to make a contribution to Numpy and I found this enhancement on the issue list. I don't have that much free time, so it would likely take a while for me to work on this issue.

I have a couple questions: Is this enhancement a high priority for Numpy development? Do you know of other issues that are likely a higher priority than this one?

For context, I'm a first-time contributor to this project, so I'm not really sure what the important issues are.

[aijams]

I just saw that you already have a PR out for this issue that hasn't yet been merged in. I will therefore let you continue working on this.

Do you still wish to get this PR merged?