search

numtel / meteor-lazy-bundles

Create bundles for lazy-loading components, optionally with authentication
Other
29 stars 2 forks source link

Incompatible with Meteor 1.2 #4

Open dbismut opened 9 years ago

dbismut commented 9 years ago

Hi - thanks for the amazing package.

Unfortunately, with Meteor 1.2, the plugin triggers the following error in the terminal:

While loading plugin `compileBundles` from package `numtel:lazy-bundles`:
   module.js:338:15: Cannot find module
numtel commented 9 years ago

With the new build system in 1.2, it looks like everything has changed related to the way this package works. It's not just a simple matter of changing the paths to the build files, it seems that the package will need to account for the structural changes.

I'm not sure when I'll have time to do this so I've added the "help wanted" label in case somebody else wants to dive into it.

joshua1 commented 8 years ago

thats sad

numtel commented 8 years ago

Yeah... :disappointed:

I have looked at this for a few hours since. With the filenames for the Meteor tool files updated, the compiler only gives a list of the included files, not the output of the final version. I'll try to take another look into this soon, it would be nice to have it fixed.

dbismut commented 8 years ago

Since that was important for me, I decided to have a go with Webpack + React and code splitting. It's hard to get used to it, coming from Meteor build system and Blaze and switching to Webpack to React require some time to get used to, but it does seem to work.

joshua1 commented 8 years ago

I have had to reverse my project back to 1.1 for this singular reason.