numtide / blueprint

Nix without the glue code
40 stars 3 forks source link

Merge legacyPackages and packages in perSystem #7

Closed brianmcgee closed 2 months ago

brianmcgee commented 3 months ago

Is your feature request related to a problem? Please describe.

When using https://github.com/numtide/devshell I cannot use perSystem.devshell.mkShell because of the following:

https://github.com/numtide/blueprint/blob/4f88aed098967ce762574efd1717277dac7c6286/lib/default.nix#L23-L25

This prefers the packages attribute over legacyPackages, and in the case of devshell it exposes different things between those two attribute sets.

Describe the solution you'd like

I'm not sure what the correct solution looks like. Maybe a recursive merge, giving precedence to packages?

Describe alternatives you've considered

For now I'm using inputs.devshell.legacyPackages.${system}.mkShell.

zimbatm commented 3 months ago

Same, no immediate good answer comes to mind. One it would be good to move away from legacyPackages, but then we need an answer to per-system lib constructors like devshell.mkShell.

zimbatm commented 2 months ago

fixed in #17