numtide / devshell

Per project developer environments
https://numtide.github.io/devshell/
MIT License
1.18k stars 86 forks source link

Add nested commands #290

Open deemp opened 6 months ago

deemp commented 6 months ago

Partially addresses #216.

Based on #295, #297 because these PRs introduced some important changes.

zimbatm commented 6 months ago

Let me know when it's rebased!

deemp commented 6 months ago

@zimbatm, rebased.

deemp commented 6 months ago

There are some problems with types. I'll let you know when this PR is ready.

deemp commented 6 months ago

@zimbatm, this PR is ready for a review.

zimbatm commented 6 months ago

hmm, are you able to extract those cleanups in a separate PR? sorry the PR is a bit too large still

deemp commented 6 months ago

Okay, now, this PR is based #295 and #297

zimbatm commented 6 months ago

thanks, let me get those merged and then I'll do a deeper review here