Modules Structure: separate (nixos) config from options

[hsjobeki]

When playing around with nixos-facter-modules i noticed that the files could be a bit optimized.

• somebody may want to import only the interface (options) but also would need to import all the nixos modules, because it sets config options in the same files.

# broadcom.nix
{ lib, config, ... }:
let
  inherit (config.facter) report;
  cfg = config.facter.networking.broadcom;
in
{
  options.facter.networking.broadcom = with lib; {
   # ...
  };

  config = {
    hardware.enableRedistributableFirmware = lib.mkIf cfg.full_mac.enable (lib.mkDefault true);

    boot = lib.mkIf cfg.sta.enable {
      kernelModules = [ "wl" ];
      extraModulePackages = [ config.boot.kernelPackages.broadcom_sta ];
    };
  };

}

[brianmcgee]

@hsjobeki is it generally better practice to define options separately from config?

[hsjobeki]

@hsjobeki is it generally better practice to define options separately from config?

Yes. I'd say so. But i havent seen any general recommendation ruleset. But that should be on it.