numtide / nixos-facter

Declarative hardware configuration for NixOS [maintainer=@numtide]
https://numtide.github.io/nixos-facter/
Other
141 stars 3 forks source link

Reports gets very large #63

Closed Mic92 closed 2 months ago

Mic92 commented 2 months ago

I have reports here that are 50k lines (100KB): https://github.com/TUM-DSE/doctor-cluster-config/blob/a33464567de498f534921c6b69329e4068f7aa8d/hosts/xavier-factor.json

CPUs seem be a substantial port of it. We don't need an entry for each CPU core but instead just one per CPU socket. Cache objects are also not interesting just now.

Mic92 commented 2 months ago

There is also quite a bit redundancy between "detail" structs and the normal struct. Why not just merge "detail" into the base struct. That would make processing in nix easier.

brianmcgee commented 2 months ago

This was a first pass at modeling, sticking to what hwinfo provided. I agree though, we can merge the detail info into the parent hardware device model.

And yes, we can probably merge CPU info as well. Just need to be careful how we do that. Might get you to provide some dumps from multi socket machines to see what that might look like so I create the right merge key.