search

nunchuk-io / libnunchuk

GNU General Public License v3.0
57 stars 10 forks source link

No CPFP support in nunchuk #22

Open DeusDenton opened 1 year ago

DeusDenton commented 1 year ago

Nunchuk (I've tested Android, iOS and Linux versions) really doesn't like CPFP transactions.

I did the following:

  1. Send coins from another service to address A that is part of a single-sig wallet Nunchuk knows about, with too low a fee rate
  2. After a while, I used another wallet (Sparrow) to CPFP the transaction, sending the unconfirmed coins with a higher fee rate from address A (which has the incoming mempool transaction) to address B in the same wallet
  3. This transaction went through, and address B now has a confirmed transaction with the original coins I sent
  4. However, nunchuk now shows an incorrect state for this wallet - the balance does not reflect this new transaction, the original transaction to address A is still showing as unconfirmed, and when I try to "receive" for this wallet in nunchuk it shows address B, which actually has a transaction in it!

With a different, multisig, wallet I've also tried creating a CPFP transaction in Sparrow and then scan the PBST QR code to add a signature in Nunchuk, which normally works, but doesn't do anything if the transaction is CPFP.

It seems the app just doesn't know what to do with CPFP at all.

seaplusplus commented 1 month ago

I think I bumped into this. I am importing an old wallet with a long history. the CPFP transactions are ignored so the balance does not reflect reality.

bakaoh commented 1 month ago

hi @seaplusplus what app version did you use? libnunchuk support CPFP since this commit https://github.com/nunchuk-io/libnunchuk/commit/ac338bdc7d903d34f7eb8b3cc179f3d7f0ffae82

seaplusplus commented 1 month ago

hi @seaplusplus what app version did you use? libnunchuk support CPFP since this commit ac338bd

I'm sorry I don't think my issue is related to CPFP. Its unrelated to this ticket.

I'm just getting an incorrect balance importing a Samurai post mix xpub. I will spin up my own electrum server and see if that fix's it.