search

nunchuk-io / nunchuk-desktop

GNU General Public License v3.0
75 stars 10 forks source link

Scanning of keystone qr fails #13

Closed Funman2 closed 2 years ago

Funman2 commented 2 years ago

If I scan a signed transaction airgapped with seedsigner it fails to scan and an error message pops up, within mobile app it scans/ signs successfully with same signer though. It seems to try multiple times on android and only once on windows, hence it always fails to import the signed transaction...

Funman2 commented 2 years ago

So i can scan now with linux ubuntu using Droidcam HD, but everytime it scans the seedsigner qr, I get this error message ( Happens always, i could scan 2 times in the beginning without error and broadcast the transaction, but then it started failing always!) On Android, same keys and wallets always scan sucessfully though even when executed on laptop in Bluestacks android player(virtual) it always scans sucessfully(!) even when using the shitty laptop low resolution HP webcam 50... So this is a linux client problem, same happens on other windows machine, it always fails even with high resolution HD cams, it only scans once, then error. Where on Android it keeps scanning until success always works there! Bildschirmfoto von 2022-07-07 09-38-38

tongvanlinh commented 2 years ago

@Funman2 thanks for your feedback, I'm on debugging for QR scan with keystone hardware. I will share you soon

Funman2 commented 2 years ago

I am scanning with seedsigner though...

tongvanlinh commented 2 years ago

@Funman2 Can you try this version and see if it's any better? It's for linux

Funman2 commented 2 years ago

Will try tonight after work, Europe time! Thanks!

Funman2 commented 2 years ago

Well, I happen to get the same error message like 8 times, but then it scanned successfully! I could sign a transaction. 2nd, the same happended, like 10 times scan aborts/terminates with error, but then eventually i get a success. I have the feeling I have to hold the QR generator( in my case Seedsigner) at a certain distance from camera, but I also could be wrong. Anyhow got a lot of errors, before it actually signed, each time I had to reopen and start allover the scanning process, but in android it just keeps scanning until success, this would be way more convenient to have it like this in desktop app similar, so you would not have to initiate so many different attempts... Many thanks for your efforts though, Nunchuk has a great looking interface with many cool features!

tongvanlinh commented 2 years ago

@Funman2 There are some optimizing in this version, could you check it and tell me your result, I think it's better than last version

Funman2 commented 2 years ago

HEY MAN YOU DID IT!! Wow great! It scans totally successful every single time now, I could immediately sign a multisig transaction with Seedsigner now, repeated the process 3 times to be sure, but I could now import the signed PSBT via QR without any failure every time! Guess you fixed it, congrats on your skills! The only thing you should change is the success message from " import the successful"(wrong grammar) to "imported successfully" or " Import successful". Great work! Now I can at least run Nunchuk Desktop on a virtual Linux machine!Awesome! Thx again.

tongvanlinh commented 2 years ago

@Funman2 thanks man :). Copy text is my mistake (copy but not fully ^^), I'll update soon. Official release will be soon as well

Funman2 commented 2 years ago

One minor little thing for this version I saw: In the menu when creating a transaction the option to export QR now only shows the text:"export to Keystone" not "export to keystone/seedsigner" Thx again! In my opinion this issue should be closed now, no?

tongvanlinh commented 2 years ago

@Funman2 yeap, it can be closed, I will update the copy text. Thank for your feedback. If you face other issue, let me know,