nunchuk-io / nunchuk-desktop

GNU General Public License v3.0
75 stars 10 forks source link

signed Transaction from Desktop does not import to mobile android #41

Closed Funman2 closed 1 year ago

Funman2 commented 1 year ago

With airgapped signature, the signature does not import to android app anymore. but signed tx from android do import in desktop app. Using primary account.

tongvanlinh commented 1 year ago

@Funman2 thank you, we're looking for it.

Funman2 commented 1 year ago

by the way , really great upgrades in 1.9.19 and android ! I closed a lot of issues! performance a lot better!

Funman2 commented 1 year ago

also I noticed canceling of transaction does not sync on any device either.

tongvanlinh commented 1 year ago

@Funman2 Thank you very much for your your great contribution to nunchuk. Hope that nunchuk will become your favorite wallet. Generally I'm trying to handle sync issues between devices and platforms. It would be good soon

tongvanlinh commented 1 year ago

1.9.19 still on pre release version, you can use it as well, official version will on next week with some other improvements

Funman2 commented 1 year ago

Looking forward! Nunchuk collab feature already is my favorite!
The sync issue might be on the android app, because in desktop the signature from android imports just fine. Just the desktop signature does not import to android version. Anyway the fee adjustment now works. Also log in time much faster! You are most welcome for reporting, hope it helps.

Funman2 commented 1 year ago

One more info for you: When I only had 2 devices logged into the primary account one other Windows machine with version 0.9.16 and one android, the transaction imported into android from desktop and the other way round just fine, also canceling imported fine! When i updated to version 1.9.19, the signature from desktop app did not import to android anymore...

tongvanlinh commented 1 year ago

@Funman2 we're checking it. Pls don't remove your db. Because it may impact to encrypted (public key) in your account We will inform soon

Funman2 commented 1 year ago

Signature still does not export to android version in this release 1.9.19

Funman2 commented 1 year ago

Hey I once again checked to recreate a collab multisig wallet with a new primary account. Same result, Desktop version fails to export signature to android version. Other way round it´s working. Also I noticed, when I signed on desktop using airgapped key, first the signature is only seen in wallet tab, it is not seen in the messenger tab, only after restart of the app it is seen in messenger. But still does not sync with android. Also the signing key is not recognized by the name given to it in desktop wallet anymore, as in prior versions it was seen as a locally stored key. Hope these details give some hint...

Funman2 commented 1 year ago

Hey I tested new Version 1.9.20 it looks great! But still the airgapped signature from Desktop does not export to android after signing...only android does import to desktop.

Funman2 commented 1 year ago

This morning I tested again with version 1.9.17. The TX imports to latest android version just fine! But with version 1.9.20 still no success.

tongvanlinh commented 1 year ago

@Funman2 we also debuging on this. Maybe it happend from our library. We will make patch fix for this

Funman2 commented 1 year ago

Also I want to inform you, i tried , on another laptop with smaller screen (15), Seedsigner won´t scan the QR code. had to magnify it, then it will scan.It would be nice to have a magnify Option for the QR window... Where as on my 19 screen laptop it scans without issues. Should I open another issue for this?

Funman2 commented 1 year ago

Also i noticed in Version 1.9.20 after signing sucessfully, after closing the sign window, the desctop version does not show the signature in messenger! Only when switching to wallet tab. This might be the issue here. After restart of nunchuk it shows the signed tx in messenger but does not export...

Funman2 commented 1 year ago

Hey, I saw you pushed a new version today. Unfortunately the signatures still don´t sync to android version once signed in desktop, using airgapped key. Also when signed in desktop version, the signature only shows in wallet view, not in messenger, if I restart the app it also shows signed in messenger but does not sync to android. Signature from android imports fine to desktop.

tongvanlinh commented 1 year ago

@Funman2 can you share more info about:

We tried some behavior that we thought same your case, but it's worked

Funman2 commented 1 year ago

Hey sure, it´s a standard collab wallet with primary key as login. No assist wallet. I tried my existing multisig with a 2 of 3 multisig setup, all 3 keys set up seperatly on 2 android devices and one windows desktop. Used seedsigner. I tried this with 2 different primary accounts and two different desktop machines also one linux vm, always same result. It used to work and still works just fine with verion 1.9.17 ...sync no problem. But in new versions since 1.19.19 it does not work anymore.

So the step is iI initialized the TX on desktop, then signed on desktop via airgapped seedsigner, then the TX shows up fine in android but the signature does not import. When signing on android it imports fine to desktop, I could broadcast, but in android it still shows only one signature...

tongvanlinh commented 1 year ago

@Funman2 thank you. I will get more support from you soon, now we're checking base on your info.

tongvanlinh commented 1 year ago

@Funman2 Please help me check this on your case. LINK HERE

Funman2 commented 1 year ago

Hey success! It worked right away in this version! Great, finally! Loading time is a little longer for decrypting the app hangs quite for some time, but once everything is loaded it works fine now. Thanks!!

Funman2 commented 1 year ago

Tested one more time with other order with different android device and it also worked flawlessly! Congrats, looks like i can hodl now with nunchuk multisig collab! Awesome.

Funman2 commented 1 year ago

one more little detail, when I cancel the TX in desktop, the cancelation syncs fine to android, but when I cancel the tx in android it does not sync the cancelation to desktop and also not to another android device,...i would have to cancel in each device on its own...but this is a minor issue.

tongvanlinh commented 1 year ago

@Funman2 thank you. We will checkit in android version

JayceLuong commented 1 year ago

Hi @Funman2 Can I check if the export key works or not? If it doesn't work, could you use Test Net and send me the export file? I will try to import and debug.

Funman2 commented 1 year ago

Hi @Jayce the key and the signature export now works fine in latest version pre7, just if I cancel a signed transaction it does not export from android to other devices, regardless if there other device is android or desktop. I never used testnet will try and debug but it will take some time since i am busy with my profession these days...