search

nunchuk-io / tap-protocol

Coinkite Tap Protocol
MIT License
15 stars 4 forks source link

Integrate libsecp256k1 cmake #13

Closed giahuy98 closed 7 months ago

PeteClubSeven commented 8 months ago

Seems to working fine with Satscards on Android. I tested with NDK 21 and 26 so it also would solve https://github.com/nunchuk-io/tap-protocol/issues/4. I can read Tapsigners in my example app but I don't have the functionality implemented to test more than that with my library.

I will test iOS in a few hours but I suspect it will work much the same.

PeteClubSeven commented 7 months ago

It seems to be working fine across Ubuntu and Mac when building for Android (NDK 21 and 26) as well as iOS as you can see here https://github.com/PeteClubSeven/cktap-protocol-flutter/actions/runs/7577205789

I tested it with Tapsigners and Satscards on my iPhone SE 2022 and my Fairphone 4. Both seem to be functioning the same as they were previously, however I haven't extensively tested all the functionality of the tap-protocol library.

giahuy98 commented 7 months ago

Awesome, thank you! Merge this for now.