search

nunchuk-io / tap-protocol

Coinkite Tap Protocol
MIT License
15 stars 4 forks source link

Fix 64-bit Android ABIs & allow manual ABI selection #3

Closed PeteClubSeven closed 1 year ago

PeteClubSeven commented 1 year ago

Hi, I'm submitting fixes for the supported 64-bit ABIs (arm64-v8a & x86_64), details of which can be found in f173e63c2356fd0cabbaf3ea3abfdf8840b09088. Additionally I added a feature where you can manually specify the ABI to build for secp256 on Android, 20400fa1da1b3851aadfeab31103505372968593.

This PR also fixes https://github.com/nunchuk-io/tap-protocol/issues/2

giahuy98 commented 1 year ago

Thank you for the PR! Everything looks good now, but going forward, we plan to eliminate the building script and instead use libsecp256k1 (https://github.com/bitcoin-core/secp256k1/pull/1113) directly in our CMakeLists.txt

PeteClubSeven commented 1 year ago

Thank you for the PR! Everything looks good now, but going forward, we plan to eliminate the building script and instead use libsecp256k1 (bitcoin-core/secp256k1#1113) directly in our CMakeLists.txt

Thanks for letting me know, this particular improvement was useful for me but I'll refrain from modifying further unless absolutely necessary