search

nunit / docs

Documentation for all active NUnit projects
https://docs.nunit.org
MIT License
601 stars 152 forks source link

General page on .NET Core only talks about the adapter #233

Open CharliePoole opened 6 years ago

CharliePoole commented 6 years ago

This page https://github.com/nunit/docs/wiki/.NET-Core-and-.NET-Standard is at the top level of the general NUnit menu, but it only gives info about using the VS adapter. Either it should be located under the adapter portion of the documentation or it should be more general.

IMO the best resolution would be a general page at the top level with a link to this specific information under the adapter.

BTW - I can't update it myself because I was actually looking for the information that would tell me why I can't build some of our projects any longer!

rprouse commented 6 years ago

I put this information at the top level where it would be very obvious because we are getting so many issues reported around .NET Core, .NET Standard and the new CSPROJ format. It only talks about the adapter because the only ways to run .NET Core tests currently is using the adapter or NUnitLite. We could add the NUnitLite information, but it isn't any different than the normal NUnitLite info, so we could just link to that.

CharliePoole commented 6 years ago

I was trying to figure out why I can't build the engine and I had the brilliant idea to look at our own docs! Unfortunately it didn't help me. There is nothing I can see either in the wiki or in BUILDING.md that address the particular pre-requisites one needs.

Regarding NUnitLite ... are you saying there's .NET core info for it?

ChrisMaddock commented 6 years ago

@CharliePoole As a possible solution, last time I had to build the engine I needed to purge the repo first. I assume there was some old dependencies copied around that were confusing things.

rprouse commented 6 years ago

@CharliePoole the help documents that I referred to are for .NET Core consumers not contributors. I thought that I had separated out the .NET Core dependencies in the engine project to keep them backwards compatible, but if that is the case, then please post your errors and we will figure it out and hopefully document the fix 😄

The hoops we jump through to maintain backwards compatibility limit us to very specific versions of .NET Core as opposed to any latest version. That causes problems for people and is one of the reasons I would like to start migrating to the new csproj format because it generally just works if you have recent bits installed.