nunit / docs

Documentation for all active NUnit projects
https://docs.nunit.org
MIT License
602 stars 149 forks source link

Place explanations about filtering in their note block #927

Closed chm-tm closed 2 months ago

chm-tm commented 2 months ago

This is cosmetics. I tried to meaningfully complete what seemed an unfinished first sentence.

chm-tm commented 2 months ago

@dotnet-policy-service agree company="Triamec Motion AG"

OsirisTerje commented 2 months ago

Thanks @chm-tm ! The "rules" here is a bit picky on linting :-) Line length it looks like.

chm-tm commented 2 months ago

@OsirisTerje I'm stuck here. Seems the personal access token is missing.

SeanKilleen commented 2 months ago

This looks good to go -- the issue with the failing build in the last round of changes is just upon generating the deployment preview. I will maybe split that into a separate build step so that it's more obvious in the future, as it sometimes fails but doesn't indicate a PR problem necessarily.

Thank you for the contribution, @chm-tm!