search

nunit / dotnet-test-nunit

Deprecated test runner for .NET Core. For use with project.json only. For recent releases of .NET Core, use the NUnit 3 Visual Studio Adapter
https://www.nuget.org/packages/dotnet-test-nunit/
MIT License
67 stars 25 forks source link

Fixes net451 issues #54

Closed ghost closed 8 years ago

ghost commented 8 years ago

Fix #45 And possibly #37

rprouse commented 8 years ago

AppVeyor failure is an incompatible branch name.

rprouse commented 8 years ago

Looks good. I assume you have tested it?

ghost commented 8 years ago

@rprouse, based on the multiple conversations in dotnet/cli, xunit/xunit and xunit/dotnet-test-xunit, I believe this is the most appropriate fix for these issues (as consumers of package won't need to add any extra dependency in their project); but since I cannot reproduce #45 on my system or AppVeyor, we would need to wait for @ejball's reply for this comment: https://github.com/nunit/dotnet-test-nunit/issues/45#issuecomment-233147685. :)

ghost commented 8 years ago

@rprouse, @elbaloo confirmed that this patch fixes the issue. Should we merge this for next beta?

rprouse commented 8 years ago

Looks good, thanks. I am planning on doing an RC or beta this week. Anything you think we should make sure we include?

ghost commented 8 years ago

Thanks. I think with command line argument parsing included, this is going to be a great update! As such, I can't think of anything of release-blocker nature. However, I will keep an eye on issues. :)