Installing the nunit.engine adds nunit.engine.nuget.addins to the csproj

nunit / nunit-console

NUnit Console runner and test engine

MIT License

215 stars 151 forks source link

Installing the nunit.engine adds nunit.engine.nuget.addins to the csproj #723

Open ChrisMaddock opened 4 years ago

ChrisMaddock commented 4 years ago

This isn't intentional. This addins file is just linked to the file in the package itself, which means any edits would be lost on package restore. We probably need to fix this for 3.11.

CharliePoole commented 4 years ago

May just be a doc fix. Users should not edit our addins files but should simply add their own in addition.

ChrisMaddock commented 4 years ago

@jnm2 - I think this has happened with the change to contentFiles. Any idea's how we might prevent this? I've had a dig, but not much luck. 😢

I think we really just want this file to be copied over to bin like the agents - but not be shown as part of the VS project. This is using PackageReference, btw.

CharliePoole commented 2 years ago

This was once confirmed but we need to re-confirm using the latest release.