search

nunit / nunit-project-loader

The NUnit project loader extension allows the NUnit engine to load nunit projects
MIT License
2 stars 6 forks source link

Support .NET Core #15

Closed runehalfdan closed 4 years ago

runehalfdan commented 4 years ago

Updated project-file to target both .NET 2.0 and .NET Core 2.1 Updated packages to contain both builds under Tools

dnfadmin commented 4 years ago

CLA assistant check
All CLA requirements met.

runehalfdan commented 4 years ago
  • We are not testing the new build at all as far as I can see. We should run the unit tests over both versions.

As I understand, Cake uses NUnit Console Runnere to run tests, and it doesn't support running .NET Core test yet. But I'll make it better prepared to do so when it is supported.

  • We are still running tests using NUnit3-console 3.7. We could update that, of course. There's a more general question about testing extensions with multiple versions of the engine, but that's probably not for here.

I missed that one. Using 3.11.1 now.

CharliePoole commented 4 years ago

@runehalfdan Yes, to run the tests for the new build, you would have to stop using the Cake NUnit 3 extension and run the beta .net core console for those tests. It's up to you, I think, whether you want to go that far on this PR.

runehalfdan commented 4 years ago

@runehalfdan Yes, to run the tests for the new build, you would have to stop using the Cake NUnit 3 extension and run the beta .net core console for those tests. It's up to you, I think, whether you want to go that far on this PR.

I think I'll pass on that for now. But except for the 'skip using Cake NUnit3' everything should be ready for it.

ChrisMaddock commented 4 years ago

Hi both.

Thanks for pulling this all together Dan! Afraid I’m going to be unavailable for the next 1-2 weeks to have a proper look, will try and get to it then. On the other hand - Charlie - please feel free to run this through to release if you’re willing. I don’t consider these extensions part of the Engine project - just something I’m happy to help sort out (with all of Dan’s work!), while there is no official maintainer.

One thought - have you managed to test this being installed as a NuGet package, with the console, Dan? I’d have expected you’d need an additional .addins file to make it work, as my comments on the other thread. Perhaps I’m wrong, however. 😊

runehalfdan commented 4 years ago

Hi both.

Thanks for pulling this all together Dan! Afraid I’m going to be unavailable for the next 1-2 weeks to have a proper look, will try and get to it then. On the other hand - Charlie - please feel free to run this through to release if you’re willing. I don’t consider these extensions part of the Engine project - just something I’m happy to help sort out (with all of Dan’s work!), while there is no official maintainer.

(I'm Rune Halfdan :) )

One thought - have you managed to test this being installed as a NuGet package, with the console, Dan? I’d have expected you’d need an additional .addins file to make it work, as my comments on the other thread. Perhaps I’m wrong, however. 😊

I haven't had a good chance to actually run these plugins with the latest console runner yet. I might find some time tomorrow, but after that I too will be unavailable for the next two weeks.

ChrisMaddock commented 4 years ago

Whoops - sorry, Rune! 😊

CharliePoole commented 4 years ago

@runehalfdan @ChrisMaddock

Based on some other projects, I'm pretty sure this can't get any better unless we either raise the version of Mono or stop building with Mono. The latter is what I've done with several other nunit projects and with my own non-nunit projects. I switched to using the cake global tool and running the builds under .NET Core in all environments. Testing can still be done under mono.

Since you're going to be gone for a while and I already have build scripts that do that, I think the best thing to do is merge with the travis build failing and then start a new PR.

@runehalfdan If you're interested we'd very much like to have you as part of the team that maintains these extensions. One problem we have is that some of us no longer use them in our work, which means they get less attention.

Thanks for all the work, Rune! Please check in when you are back.