Integrate creation of chocolatey packages

nunit / nunit-project-loader

The NUnit project loader extension allows the NUnit engine to load nunit projects

MIT License

2 stars 6 forks source link

Integrate creation of chocolatey packages #9

Closed CharliePoole closed 7 years ago

CharliePoole commented 7 years ago

Fixes #8 and will be a model for the other extensions as well.

I've added comments inline to explain some choices I made. @nunit/core-team Please take a look as this will be the basis for the other extensions as well as the runners.

Also fixes #2

ChrisMaddock commented 7 years ago

I added 'fixes #2' to your opening post, and hopefully this will also fix #7 once the paths are corrected. 😄

CharliePoole commented 7 years ago

Apparently our standard .gitignore file doesn't have .nupkg in it.

CharliePoole commented 7 years ago

@ChrisMaddock Here's an idea...

Package depends on Build, PackageNuGet, PackageChocolatey
PackageNuGet and PackageChoco no longer depend on build
Normal builds use Package as the target
If we are repackaging, we probably only want to do it for one of the two packages, so we set up the directory containg binaries and do either PackageNuGet or PackageChocolatey.
We could also add a dependent task to the PackageTarget that checks the arguments. The binaries argument should be null if we are running Package.

ChrisMaddock commented 7 years ago

That all seems sensible.

To be honest, I'm not too worried here. I feel like repackaging is an unusual enough task, it's ok for it to include some manual steps. I just thought it was your intention, to have the two stages separate again, like we used to.

CharliePoole commented 7 years ago

@ChrisMaddock I would prefer to have them separate. Others in the @nunit/core-team have asked for the dependency to be retained - at least as I understood the comments.

With the dependency, whoever releases just runs the Package target. The extension is built and the result is packaged. Repackaging still works, by using PackageNuGet or PackageChocolatey

Without the dependency, they have to

Run the build or test target or otherwise verify that the binaries are up to date
Run the package command Repackage works the same as without the dependency.

@nunit/core-team What is your pleasure? I think it will be best if we eventually make all our build scripts work in whichever way we decide.

CharliePoole commented 7 years ago

New commit - @nunit/core-team I'd appreciate a re-review.

No more nuspecs - it's all done in build.cake
Changed dependencies and added a RePackage target
Error if you use Build or Package with the --binaries option

Further suggestions?

CharliePoole commented 7 years ago

Looks like I lost my CreateDirectory command.

CharliePoole commented 7 years ago

I think this should now be ready to merge. Most recently, I've been working offline at creating the same script for the vs-project-loader with the result that I reorganized so the items I needed to change are in one section at the top of the script.

Also updated to run tests with latest console runner.