search

nunit / nunit-vs-adapter

Runs NUnit V2 tests inside the Visual Studio 2012 or later Test Explorer window.
MIT License
50 stars 43 forks source link

Make a Visual Mark on Test Results #103

Open feinstein opened 8 years ago

feinstein commented 8 years ago

The native Visual Studio Tests have a check mark on everything related to that test, for example:

captura_de_tela_031616_041224_am

I don't know if it's possible to mimic this functionality, but it will be a nice addition.

OsirisTerje commented 8 years ago

You mean like this ? image

feinstein commented 8 years ago

With the Test attribute it works....but not with the TestCase attribute:

captura_de_tela_032416_053905_pm

Even though the Test Explorer does show the completed successful tests with a check mark:

captura_de_tela_032416_054043_pm

CharliePoole commented 8 years ago

Does the explorer window show the correct file location for the test method? If not, there may be something we can fix. But if it does, that means we are passing the correct info to VS and it's basically up to them to do something with it. :-(

feinstein commented 8 years ago

Yes, I think it is showing the right file location...can you make a simple test like mine and see if this isn't something isolated?

CharliePoole commented 8 years ago

I have verified this behavior using the NUnit 3 adapter rather than NUnit 2, which seems to indicate it's just how it works with VS.

The behavior makes a certain amount of sense. If a method is parameterized and has twenty cases, potentially having differing results, then what would be shown?

I'd like to close this as notabug if nobody objects.

feinstein commented 8 years ago

Well, I think if it has 20 cases, and all of them pass, so there should be a green check mark...if one fails, even if the others pass, there should be a red warning....Just like it is in the Test Explorer.

CharliePoole commented 8 years ago

Perhaps, but definitely not in our control.

feinstein commented 8 years ago

I see....do you have a channel of communication with Microsoft to raise this issue with them? I think this will be a nice addition.

CharliePoole commented 8 years ago

@OsirisTerje can you try? They don't talk to me for sure.

OsirisTerje commented 8 years ago

I'll talk with them again, but I've done so earlier. The indicator is not part of the test explorer itself, but is a CodeLens "extension" they have. Not sure how it is related, but I'll ping them again.

CharliePoole commented 8 years ago

Thanks @OsirisTerje

If this turns out to be something they don't expect to change anytime soon, I think we should just close it as not our bug.