search

nunit / nunit.xamarin

NUnit test runners for Xamarin and mobile devices - No longer maintained
http://nunit.org
MIT License
50 stars 46 forks source link

Create Test Suite #88

Open ChrisMaddock opened 7 years ago

ChrisMaddock commented 7 years ago

This project has grown fairly rapidly. There's currently only a mock test suite to manually review runner behaviour, ideally there should also be unit tests of functionality.

I'd wonder if it's worth addressing this after #48 - as that will include some fairly fundamental changes to the architecture. #48 could be addressed in the interim by using the portable.agent, which I think provides a similar interface to the engine, and would make the later switch far simpler.

Assigning this to vNext, we should get this in before it grows much further!

felipetozato commented 5 years ago

Hi @ChrisMaddock, How are you? I'm currently checking something to help on this project and found this issues due to it's mention in #115. Do you think it is worth attacking this issue, with the portable.agent approach (I understand it is this project https://github.com/nunit/nunit.portable.agent)? I'm asking because issue 48 does not receive updates in a while.

ChrisMaddock commented 5 years ago

Hey @felipetozato!

The .NET Standard engine required to do #48 in the way we want to is actually nearly ready - the work is done in a branch here: https://github.com/nunit/nunit-console/tree/issue-388b - it just needs the final touches, review and merging etc. As such, it's probably not the best time to start work on plugging in the portable agent, as we'll want to replace it again within the next few months.

So, I'd recommend not starting on #48 quite yet - although if you'd be interested in picking that up once the .NET Standard engine is merged - we'd love the help then! In terms of this issue, I'd imagine some of the work could be done before #48 is done - I think it could be started on independently. 🙂

Tagging in @rprouse who's the maintainer of this project (I don't do any work on nunit.xamarin anymore) - but I'm pretty sure @rprouse and I have the same opinion here!

felipetozato commented 5 years ago

Cool! I'm gonna start adding some tests, probably starting on ViewModels.

Thanks!

ChrisMaddock commented 5 years ago

Awesome, thanks!