search

nunit / nunit3-vs-adapter

NUnit 3.0 Visual Studio test adapter for use under VS 2012 or later
https://nunit.org
MIT License
203 stars 105 forks source link

Exclude the partition filter from test expansion #1179

Closed chris-smith-zocdoc closed 2 months ago

chris-smith-zocdoc commented 4 months ago

Addressing my comment here https://github.com/nunit/nunit3-vs-adapter/issues/1138#issuecomment-2116067823

I saw the category filter doing this already and copied its approach. Please let me know if there is another approach you think I should take

chris-smith-zocdoc commented 4 months ago

@dotnet-policy-service agree company="Zocdoc"

OsirisTerje commented 2 months ago

@chris-smith-zocdoc Can you update?

chris-smith-zocdoc commented 2 months ago

@OsirisTerje I rebased, is there anything else I should do?

If this approach is good with you I can also add tests, just need some guidance on where they should go and how to run them (I'm on Mac and am unfamiliar with Cake)

OsirisTerje commented 2 months ago

@chris-smith-zocdoc Thanks!

Building with cake is straightforward. I am not familiar with Mac command line, but if you can run either the build.cmd file or the build.ps1 (powershell), or you can create a similar one for Mac,

To build: build To test: build -t test To run the acceptance tests: build -t acceptance (And for reference, to build a nuget package: build -t package)

The acceptance tests uses code for the test project and test class embedded in the test. It then starts up the test system, includes the adapter package and run it.

OsirisTerje commented 2 months ago

@chris-smith-zocdoc I'll merge this now, in order to get it into version 4.6.

Would be nice if you managed to get some tests around it though, but it can in a separate PR.