search

nunit / teamcity-event-listener

NUnit Engine extension that helps integration with teamcity
MIT License
11 stars 10 forks source link

Integrate chocolatey package creation into build script #43

Closed CharliePoole closed 7 years ago

CharliePoole commented 7 years ago

Fixes #41

@NikolayPianikov I'm creating the PR so you can review. We still have unexplained failures in AppVeyor and Travis, similar to the previous PR. Under Appveryor, we have integration test failures and under travis a complete failure of the nuget restore step. I feel like you understand your project better than I and may be able to figure this out.

As for the creation of the chocolatey package, I used the same logic as in the other extensions but did not reorganize the code in the same way. I'll leave it to you to keep it structured as you prefer or change it in the future.

CharliePoole commented 7 years ago

@rprouse Can you suggest what's going wrong with the Travis builds? It started when I upgraded the packages.

NikolayPianikov commented 7 years ago

@CharliePoole, I will try to reproduce issue on Linux/mono and hope it helps to find what is wrong

NikolayPianikov commented 7 years ago

@CharliePoole looks like there is some problem during resolving dependencies in NUnit package 3.7.x, I've rolled back NUnit to 3.6.1 and it is working now. By the way, this issue is also reproduced in a project from the scratch

ChrisMaddock commented 7 years ago

@NikolayPianikov - I believe the issue is caused by this repo downloading too old a version of nuget.exe. build.sh currently downloads v2.8.6, which I don't believe can handle the NUnit v3.7.1 NuGet package correctly.

Try replacing build.ps1 and build.sh with the latest versions from the link below, which download NuGet v4.1.0. (NuGet changed the download link for the latest version, which is why this repo is still fetching v2.8.6!)

https://github.com/cake-build/resources

NikolayPianikov commented 7 years ago

@ChrisMaddock thank you, it helps

NikolayPianikov commented 7 years ago

@CharliePoole, @ChrisMaddock, mono 3.2.8 still has error and I can't reproduce it locally, do you have any ideas?

ChrisMaddock commented 7 years ago

Not sure sorry, we've dropped mono 3.2.8 support on the main projects.

ChrisMaddock commented 7 years ago

Travis has recently upgraded the default Unix environment to Trusty - and looks like the package can't be found there? Maybe try adding dist: precise to the .travis.yml? (Or just dropping 3.2.8...that would be my preference! ;-) )

CharliePoole commented 7 years ago

I got rid of mono 3.28, consistent with what we are doing with other projects. Travic-ci now passes.

We still have a failing integration test in the AppVeyor pr build. What do you want to do?

NikolayPianikov commented 7 years ago

@CharliePoole I will ignore test while I do not find a problem

NikolayPianikov commented 7 years ago

@CharliePoole don't you have any objections to merge PR?