search

nunit / teamcity-event-listener

NUnit Engine extension that helps integration with teamcity
MIT License
11 stars 10 forks source link

TeamCity does not interrupt NUnit test run #54

Closed YRudievGP closed 6 years ago

YRudievGP commented 6 years ago

Tests are not stopped if cancel TeamCity run.

Steps to reproduce:

  1. Run TeamCity test run with NUnit tests
  2. When tests are started executing, cancel test run (press " stop build" button)

Result: Tests are continued executing.

Additional information: It is actually for UI and backend tests.

In use: .Net framework netcoreapp2.0 NUnit 3.10.1 NUnit.ConsoleRunner 3.8.0 NUnit.Runners 3.8.0 NUnit3TestAdapter 3.10.0 Runner type .NET CLI (dotnet)

According to TeamCity logs, when "stop build" button was pressed, docker-composeer was stopped but tests are still running.

Part of logs from TeamCity: Step 10/11: Run test by Dotnet (.NET CLI (dotnet)) (1m:01s) [12:21:50][Step 10/11] dotnet test ServerTesting/Server.Testing.SystemTests/Server.Testing.SystemTests.csproj --filter "TestCategory=bingo|TestCategory=common|TestCategory=nolobby" --configuration CI @/opt/TeamCity/BuildAgent1/temp/agentTmp/7bae7bbb359b4441ab48c293510bddc7.rsp [12:21:50][Step 10/11] test (59s) [12:21:50][test] Starting: /usr/bin/dotnet test ServerTesting/Server.Testing.SystemTests/Server.Testing.SystemTests.csproj --filter "TestCategory=bingo|TestCategory=common|TestCategory=nolobby" --configuration CI @/opt/TeamCity/BuildAgent1/temp/agentTmp/7bae7bbb359b4441ab48c293510bddc7.rsp [12:21:50][test] in directory: /opt/TeamCity/BuildAgent1/work/668a102bb75fdb62 [12:21:52][test] Сборка начата, подождите... [12:21:56][test] Сборка выполнена. [12:21:56][test] [12:21:56][test] Тестовый запуск /opt/TeamCity/BuildAgent1/work/668a102bb75fdb62/ServerTesting/Server.Testing.SystemTests/bin/CI/netcoreapp2.0/Server.Testing.SystemTests.dll(.NETCoreApp,Version=v2.0) [12:21:56][test] Программа Microsoft (R) Test Execution Command Line Tool версии 15.6.0 [12:21:56][test] (с) Корпорация Майкрософт (Microsoft Corporation). Все права защищены. [12:21:56][test] [12:21:56][test] Запуск выполнения тестов; подождите... [12:21:57][test] NUnit Adapter 3.10.0.21: Test execution started [12:21:57][test] Running all tests in /opt/TeamCity/BuildAgent1/work/668a102bb75fdb62/ServerTesting/Server.Testing.SystemTests/bin/CI/netcoreapp2.0/Server.Testing.SystemTests.dll [12:21:57][test] NUnit3TestExecutor converted 198 of 198 NUnit test cases [12:22:00][test] Server.Testing.SystemTests.dll (49s) [12:22:00][Server.Testing.SystemTests.dll] Server.Testing.SystemTests.Common.BasicStateCommon.Buddy.CAckAddBuddyTests.CAckAddBuddy_LimitOfBuddiesReached_SDeniedAddingBuddyReceived [12:22:03][Server.Testing.SystemTests.dll] Server.Testing.SystemTests.Common.BasicStateCommon.Buddy.CAckAddBuddyTests.CAckAddBuddy_Negative_BuddyAuthorizationDeclined [12:22:05][Server.Testing.SystemTests.dll] Server.Testing.SystemTests.Common.BasicStateCommon.Buddy.CAckAddBuddyTests.CAckAddBuddy_Negative_RelationDublicateIsDeleted [12:22:08][Server.Testing.SystemTests.dll] Server.Testing.SystemTests.Common.BasicStateCommon.Buddy.CAckAddBuddyTests.CAckAddBuddy_Positive_BuddyAuthorizationGranted [12:22:10][Server.Testing.SystemTests.dll] Server.Testing.SystemTests.Common.BasicStateCommon.Buddy.CAckAddBuddyTests.CAckAddBuddy_Positive_RelationDublicateIsDeleted [12:22:13][Server.Testing.SystemTests.dll] Server.Testing.SystemTests.Common.BasicStateCommon.Buddy.CAckAddBuddyTests.CAckAddBuddy_RelationInAuthorizationRequired2_BuddyAuthorizationForbidden [12:22:14][test] Stopping docker-compose for docker-compose.yml [12:22:22][Server.Testing.SystemTests.dll] Server.Testing.SystemTests.Common.BasicStateCommon.Buddy.CAckAddBuddyTests.CAckAddBuddy_RelationInAuthorizationRequired2_BuddyAuthorizationGranted [12:22:49][test] Не пройдено: CAddBuddyTests_BuddyAuthorizationInvalid_RelationAuthorizationRequiredAndSAddBuddyReceived

If I can provide any additional information, please let me know.

CharliePoole commented 6 years ago

The team city event listener does only what it's name suggests. It listens for events from NUnit and reports them to TeamCity. If this is actually a problem with some other part of nunit (like the console runner, engine or framework) we can move the issue there. However, it sounds to me like a TeamCity issue rather than an NUnit one.

@NikolayPianikov Where do you think this should be handled?

NikolayPianikov commented 6 years ago

@CharliePoole this issue is not related to teamcity-event-listener @YRudievGP could you create it here please?

YRudievGP commented 6 years ago

Thanks guys for the reply.

@NikolayPianikov I've created the issue in dotnet-plugin project. There is a link https://github.com/JetBrains/teamcity-dotnet-plugin/issues/125

This issue can be closed.

NikolayPianikov commented 6 years ago

Fixed