search

nunit / teamcity-event-listener

NUnit Engine extension that helps integration with teamcity
MIT License
11 stars 10 forks source link

Fix for #82 #83

Closed elv1s42 closed 1 year ago

elv1s42 commented 1 year ago

TeamCity doesn't support artifacts with paths containing comma character: https://youtrack.jetbrains.com/issue/TW-19333 In order to make sure the artifacts are published correctly, we are replacing the comma character with '_'. This PR is fix for https://github.com/nunit/teamcity-event-listener/issues/82

SeanKilleen commented 1 year ago

Just out of curiosity - is there a reason we wouldn't want to add , to the _invalidFileChars at the initialization, since what we're trying to say is that the , is invalid for this purpose?

It seems like that would express the purpose clearly while saving the or statement.

SeanKilleen commented 1 year ago

(Also, thank you for this PR!)

elv1s42 commented 1 year ago

Just out of curiosity - is there a reason we wouldn't want to add , to the _invalidFileChars at the initialization, since what we're trying to say is that the , is invalid for this purpose?

I agree! Changed the code a little bit. The _invalidFileChars is used only in one place, so it should not affect any other logic of the ServiceMessageFactory.

elv1s42 commented 1 year ago

Right now, I am testing if the fix is actually working. I can confirm it after some builds will finish in the TeamCity. Are there any other actions required from my side to get this PR merged?

elv1s42 commented 1 year ago

Ok, I can confirm that the fix is working, but now I'm facing another issue: https://github.com/nunit/teamcity-event-listener/issues/84

elv1s42 commented 1 year ago

Closing this PR because it doesn't fix #84