search

nunit / teamcity-event-listener

NUnit Engine extension that helps integration with teamcity
MIT License
11 stars 10 forks source link

Fix for #82 and #84 #85

Closed elv1s42 closed 1 year ago

elv1s42 commented 1 year ago

This is a simple fix for #82 and #84 The idea is that we don't need to use the test name when creating a directory for the artifact. In any case, such artifacts are published into a hidden folder .teamcity/NUnit/, so it is enough to use just Guid.NewGuid() instead of using trimmed test name with escaped special characters.

NikolayPianikov commented 1 year ago

@elv1s42 Thanks for the PR. Give me time to analyze the implications in terms of backwards compatibility.

elv1s42 commented 1 year ago

@NikolayPianikov, any updates on this please?

k15tfu commented 1 year ago

Friendly ping.

hn100823 commented 1 year ago

Hope that this could be completed soon

NikolayPianikov commented 1 year ago

Sorry for the delay. My GitHub account was suspended for a while.

hn100823 commented 1 year ago

hi @NikolayPianikov may I ask when will we have the new release for this? As I see here https://www.nuget.org/packages/NUnit.Extension.TeamCityEventListener The latest version is 1.0.7 from 2019 Will this be included in the newer version of Nunit (which version) or do we have to install it separately?

hn100823 commented 1 year ago

hi @NikolayPianikov When will the next releases of this project/issue? and When that be included in a release of the NUnit console?

NikolayPianikov commented 1 year ago

@hn100823 I plan to do it within a week. Yes, you will have to add the package manually until the NUnit.Console package is released

hn100823 commented 1 year ago

hi @NikolayPianikov, as I see the latest release is from 2019 https://github.com/nunit/teamcity-event-listener/releases Is there any issue?