nunnatsa / ginkgolinter

golang linter for ginkgo and gomega
MIT License
26 stars 6 forks source link

disable the focused container rule by default #101

Closed nunnatsa closed 1 year ago

nunnatsa commented 1 year ago

Enabling this rule by default may case issues in projects with a complex build systems.

This PR change this rule to be opt-in.

The --suppress-focus-container flag is now depracated and ignored. Instead, this PR introduces the --forbid-focus-container flag, with default value of false.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #100

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

@EdDev

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5643731922


Files with Coverage Reduction New Missed Lines %
ginkgo_linter.go 34 86.12%
<!-- Total: 34 -->
Totals Coverage Status
Change from base Build 5583607953: -3.1%
Covered Lines: 884
Relevant Lines: 1074

💛 - Coveralls