The bug is that when checking the comparison of two different types, if the matcher is WithTransform, ginkgo linter does not check the nested matcher, causing false positive for any matcher other than Equal or BeIdentical.
This PR fixes this issue by checking the nested matcher name, and only trigger error if the nested matcher is Equal or BeIdentical.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #115
Type of change
Please delete options that are not relevant.
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
[x] Added test case and related test data
[x] Update the functional test
Checklist:
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
The bug is that when checking the comparison of two different types, if the matcher is
WithTransform
, ginkgo linter does not check the nested matcher, causing false positive for any matcher other thanEqual
orBeIdentical
.This PR fixes this issue by checking the nested matcher name, and only trigger error if the nested matcher is
Equal
orBeIdentical
.Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #115
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
@nunnatsa