New rule(s): Wrong Usage of the `MatchError` gomega Matcher

[nunnatsa]

Description

The MatchError gomega matcher asserts an error value (and if it's not nil).

There are four valid formats for using this Matcher:

• error value; e.g. Expect(err).To(MatchError(anotherErr))
• string, to be equal to the output of the Error() method; e.g. Expect(err).To(MatchError("Not Found"))
• A gomega matcher that asserts strings; e.g. Expect(err).To(MatchError(ContainSubstring("Found")))
• [from v0.29.0] a function that receive a single error parameter and returns a single boolean value. In this format, an additional single string parameter, with the function description, is also required; e.g. Expect(err).To(MatchError(isNotFound, "is the error is a not found error"))

These four format are checked on runtime, but sometimes it's too late. ginkgolinter performs a static analysis and so it will find these issues on build time.

ginkgolinter checks the following:

• Is the first parameter is one of the four options above.
• That there are no additional parameters passed to the matcher; e.g. MatchError(isNotFoundFunc, "a valid description" , "not used string"). In this case, the matcher won't fail on run time, but the additional parameters are not in use and ignored.
• If the first parameter is a function with the format of func(error)bool, ginkgolinter makes sure that the second parameter exists and its type is string.

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [x] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [x] Added test case and related test data
• [x] Update the functional test

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] I ran golangci-lint

Fix #114

[github-actions[bot]]

Pull Request Test Coverage Report for Build 6811556342

• 89 of 96 (92.71%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.5%) to 84.444%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
ginkgo_linter.go	88	95	92.63%
<!--	Total:	89	96	92.71%	-->

Totals
Change from base Build 6681659461:	0.5%
Covered Lines:	1102
Relevant Lines:	1305

---

💛 - Coveralls