When I use option 2, I see a bunch of errors, like:
string, GomegaMatcher or func(error)bool are allowed
/Users/samheilbron/go/src/github.com/solo-io/gloo/test/kube2e/gateway/gateway_test.go:2119:6: ginkgo-linter: the MatchError matcher used to assert a non error type (err.Error())
/Users/samheilbron/go/src/github.com/solo-io/gloo/test/kube2e/gateway/gateway_test.go:2119:29: ginkgo-linter: MatchError first parameter (matchers2.ContainSubstrings([]string{"admission webhook", "SSL secret not found", secretName})) must be error, string, GomegaMatcher or func(error)bool are allowed
/Users/samheilbron/go/src/github.com/solo-io/gloo/test/kube2e/gateway/gateway_test.go:2281:7: ginkgo-linter: the MatchError matcher used to assert a non error type (vs.GetVirtualHost().GetOptions().GetTransformations())
/Users/samheilbron/go/src/github.com/solo-io/gloo/test/kube2e/gateway/gateway_test.go:2281:74: ginkgo-linter: MatchError first parameter (gloo_matchers.MatchProto(invalidTransformation)) must be error, string, GomegaMatcher or func(error)bool are allowed
Expected behavior
Custom GomegaMatchers, which are built correctly, should not trip a lint error
Describe the bug When I define a custom GomegaMatcher in a test, and then run the linter against that code, I see:
To Reproduce Option 1:
Option 2:
When I use option 2, I see a bunch of errors, like:
Expected behavior Custom GomegaMatchers, which are built correctly, should not trip a lint error
Additional context